add utility for instrument logging

Author: bisgaard-itis

packages/service-library/src/servicelib/aiohttp/tracing.py

@@ -22,8 +22,6 @@
 from settings_library.tracing import TracingSettings
 from yarl import URL
 
-from .. import tracing  # noqa
-
 _logger = logging.getLogger(__name__)
 try:
     from opentelemetry.instrumentation.botocore import (  # type: ignore[import-not-found]

packages/service-library/src/servicelib/fastapi/tracing.py

@@ -19,8 +19,6 @@
 from settings_library.tracing import TracingSettings
 from yarl import URL
 
-from .. import tracing  # noqa
-
 _logger = logging.getLogger(__name__)
 
 try:
@@ -72,7 +70,6 @@ def setup_tracing(
     ):
         _logger.warning("Skipping opentelemetry tracing setup")
         return
-
     # Set up the tracer provider
     resource = Resource(attributes={"service.name": service_name})
     trace.set_tracer_provider(TracerProvider(resource=resource))

packages/service-library/src/servicelib/tracing.py

@@ -3,8 +3,7 @@
 from opentelemetry import context as otcontext
 from opentelemetry import trace
 from opentelemetry.instrumentation.logging import LoggingInstrumentor
-
-LoggingInstrumentor().instrument(set_logging_format=False)
+from settings_library.tracing import TracingSettings
 
 TracingContext: TypeAlias = otcontext.Context | None
 
@@ -27,3 +26,8 @@ def attach_context(context: TracingContext) -> None:
 def detach_context(context: TracingContext) -> None:
     if context is not None:
         otcontext.detach(context)
+
+
+def setup_log_tracing(tracing_settings: TracingSettings):
+    _ = tracing_settings
+    LoggingInstrumentor().instrument(set_logging_format=False)