added 404 test

Author: Andrei Neagu

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/api/frontend/routes/_service.py

@@ -88,8 +88,8 @@ async def service_details(node_id: NodeID):
             return
 
         scheduler_internals = service_model.model_dump(mode="json")
-        service_status = scheduler_internals.pop("service_status", "null")
-        service_status = json.loads("null" if service_status == "" else service_status)
+        service_status = scheduler_internals.pop("service_status", "{}")
+        service_status = json.loads("{}" if service_status == "" else service_status)
         dynamic_service_start = scheduler_internals.pop("dynamic_service_start")
 
         ui.markdown("**Service Status**")

services/dynamic-scheduler/tests/unit/api_frontend/helpers.py

@@ -21,7 +21,7 @@
 
 
 @asynccontextmanager
-async def _take_screenshot_on_error(
+async def take_screenshot_on_error(
     async_page: Page,
 ) -> AsyncIterator[None]:
     try:
@@ -41,7 +41,7 @@ async def _get_locator(
     instances: NonNegativeInt | None,
     timeout: float,  # noqa: ASYNC109
 ) -> Locator:
-    async with _take_screenshot_on_error(async_page):
+    async with take_screenshot_on_error(async_page):
         async for attempt in AsyncRetrying(
             reraise=True, wait=wait_fixed(0.1), stop=stop_after_delay(timeout)
         ):
@@ -81,7 +81,7 @@ async def assert_not_contains_text(
     text: str,
     timeout: float = _DEFAULT_TIMEOUT,  # noqa: ASYNC109
 ) -> None:
-    async with _take_screenshot_on_error(async_page):
+    async with take_screenshot_on_error(async_page):
         async for attempt in AsyncRetrying(
             reraise=True, wait=wait_fixed(0.1), stop=stop_after_delay(timeout)
         ):

services/dynamic-scheduler/tests/unit/api_frontend/test_api_frontend_routes_service.py

@@ -61,6 +61,14 @@ async def test_service_details_no_status_present(
     await assert_contains_text(async_page, "Remove from tracking", instances=1)
 
 
+async def test_service_details_renders_friendly_404(
+    app_runner: None, async_page: Page, server_host_port: str, node_id: NodeID
+):
+    # node was not started
+    await async_page.goto(f"{server_host_port}/service/{node_id}:details")
+    await assert_contains_text(async_page, "Sorry could not find any details for")
+
+
 @pytest.mark.parametrize(
     "service_status",
     [