Skip to content

Commit fa4dabf

Browse files
committed
more refactoring
1 parent 949a886 commit fa4dabf

File tree

5 files changed

+5
-93
lines changed

5 files changed

+5
-93
lines changed

services/static-webserver/client/source/class/osparc/dashboard/GridButtonItem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ qx.Class.define("osparc.dashboard.GridButtonItem", {
185185
// overridden
186186
_applyLastChangeDate: function(value, old) {
187187
if (value) {
188-
if (["study", "template"].includes(this.getResourceType())) {
188+
if (["study", "template", "hypertool"].includes(this.getResourceType())) {
189189
const dateBy = this.getChildControl("date-by");
190190
dateBy.set({
191191
date: value,

services/static-webserver/client/source/class/osparc/dashboard/ListButtonItem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ qx.Class.define("osparc.dashboard.ListButtonItem", {
186186
// overridden
187187
_applyLastChangeDate: function(value, old) {
188188
if (value) {
189-
if (["study", "template"].includes(this.getResourceType())) {
189+
if (["study", "template", "hypertool"].includes(this.getResourceType())) {
190190
const dateBy = this.getChildControl("date-by");
191191
dateBy.set({
192192
date: value,

services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
411411
},
412412

413413
_addResourceFilter: function() {
414-
const resourceFilter = this._resourceFilter = new osparc.dashboard.ResourceFilter(this._resourceType).set({
414+
const resourceFilter = this._resourceFilter = new osparc.dashboard.ResourceBrowserFilter(this._resourceType).set({
415415
marginTop: 20,
416416
maxWidth: this.self().SIDE_SPACER_WIDTH,
417417
width: this.self().SIDE_SPACER_WIDTH

services/static-webserver/client/source/class/osparc/dashboard/ResourceFilter.js renamed to services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserFilter.js

Lines changed: 1 addition & 89 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
************************************************************************ */
1717

1818

19-
qx.Class.define("osparc.dashboard.ResourceFilter", {
19+
qx.Class.define("osparc.dashboard.ResourceBrowserFilter", {
2020
extend: qx.ui.core.Widget,
2121

2222
construct: function(resourceType) {
@@ -57,7 +57,6 @@ qx.Class.define("osparc.dashboard.ResourceFilter", {
5757
case "study": {
5858
this._add(this.__createWorkspacesAndFoldersTree());
5959
this._add(this.__createTrashBin());
60-
// this._add(this.__createResourceTypeContextButtons());
6160
this._add(filtersSpacer);
6261
const scrollView = new qx.ui.container.Scroll();
6362
scrollView.add(this.__createTagsFilterLayout());
@@ -67,7 +66,6 @@ qx.Class.define("osparc.dashboard.ResourceFilter", {
6766
break;
6867
}
6968
case "template": {
70-
// this._add(this.__createResourceTypeContextButtons());
7169
this._add(filtersSpacer);
7270
this._add(this.__createSharedWithFilterLayout());
7371
const scrollView = new qx.ui.container.Scroll();
@@ -78,7 +76,6 @@ qx.Class.define("osparc.dashboard.ResourceFilter", {
7876
break;
7977
}
8078
case "service":
81-
// this._add(this.__createResourceTypeContextButtons());
8279
this._add(filtersSpacer);
8380
this._add(this.__createSharedWithFilterLayout());
8481
this._add(this.__createAppTypeFilterLayout());
@@ -222,91 +219,6 @@ qx.Class.define("osparc.dashboard.ResourceFilter", {
222219
},
223220
/* /TRASH BIN */
224221

225-
/* RESOURCE TYPE CONTEXT */
226-
__createResourceTypeContextButtons: function() {
227-
const resourceTypeContextButtons = new qx.ui.container.Composite(new qx.ui.layout.VBox(2));
228-
229-
const studiesButton = this.__createStudiesButton().set({
230-
value: this.__resourceType === "study",
231-
visibility: this.__resourceType === "study" ? "excluded" : "visible",
232-
});
233-
resourceTypeContextButtons.add(studiesButton);
234-
235-
const permissions = osparc.data.Permissions.getInstance();
236-
const templatesButton = this.__createTemplatesButton().set({
237-
value: this.__resourceType === "template",
238-
});
239-
if (permissions.canDo("dashboard.templates.read")) {
240-
resourceTypeContextButtons.add(templatesButton);
241-
}
242-
243-
const servicesButton = this.__createServicesButton().set({
244-
value: this.__resourceType === "service",
245-
});
246-
if (permissions.canDo("dashboard.services.read")) {
247-
resourceTypeContextButtons.add(servicesButton);
248-
}
249-
250-
return resourceTypeContextButtons;
251-
},
252-
253-
__createStudiesButton: function() {
254-
const studyAlias = osparc.product.Utils.getStudyAlias({
255-
firstUpperCase: true,
256-
plural: true
257-
});
258-
const studiesButton = new qx.ui.toolbar.RadioButton().set({
259-
value: false,
260-
appearance: "filter-toggle-button",
261-
label: studyAlias,
262-
icon: "@FontAwesome5Solid/file/16",
263-
paddingLeft: 10, // align it with the context
264-
});
265-
osparc.utils.Utils.setIdToWidget(studiesButton, "studiesTabBtn");
266-
studiesButton.addListener("tap", () => {
267-
studiesButton.setValue(this.__resourceType === "study");
268-
this.fireDataEvent("changeTab", "studiesTab");
269-
});
270-
return studiesButton;
271-
},
272-
273-
__createTemplatesButton: function() {
274-
const templateAlias = osparc.product.Utils.getTemplateAlias({
275-
firstUpperCase: true,
276-
plural: true
277-
});
278-
const templatesButton = new qx.ui.toolbar.RadioButton().set({
279-
value: false,
280-
appearance: "filter-toggle-button",
281-
label: templateAlias,
282-
icon: "@FontAwesome5Solid/copy/16",
283-
paddingLeft: 10, // align it with the context
284-
});
285-
osparc.utils.Utils.setIdToWidget(templatesButton, "templatesTabBtn");
286-
templatesButton.addListener("tap", () => {
287-
templatesButton.setValue(this.__resourceType === "template");
288-
this.fireDataEvent("changeTab", "templatesTab");
289-
});
290-
return templatesButton;
291-
},
292-
293-
__createServicesButton: function() {
294-
const servicesButton = new qx.ui.toolbar.RadioButton().set({
295-
value: false,
296-
appearance: "filter-toggle-button",
297-
label: this.tr("Services"),
298-
icon: "@FontAwesome5Solid/cogs/16",
299-
paddingLeft: 10, // align it with the context
300-
});
301-
osparc.utils.Utils.setIdToWidget(servicesButton, "appsTabBtn");
302-
servicesButton.addListener("tap", () => {
303-
servicesButton.setValue(this.__resourceType === "service");
304-
this.fireDataEvent("changeTab", "appsTab");
305-
});
306-
return servicesButton;
307-
},
308-
/* /RESOURCE TYPE CONTEXT */
309-
310222
/* SHARED WITH */
311223
__createSharedWithFilterLayout: function() {
312224
const sharedWithLayout = new qx.ui.container.Composite(new qx.ui.layout.VBox(2));

services/static-webserver/client/source/class/osparc/ui/list/CollaboratorListItem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ qx.Class.define("osparc.ui.list.CollaboratorListItem", {
7676
members: {
7777
__getRoleInfo: function(id) {
7878
const resource = this.getResourceType();
79-
if (resource === "study" || resource === "template") {
79+
if (["study", "template", "hypertool"].includes(resource)) {
8080
return osparc.data.Roles.STUDY[id];
8181
} else if (resource === "service") {
8282
return osparc.data.Roles.SERVICES[id];

0 commit comments

Comments
 (0)