Skip to content

Commit faf2cf4

Browse files
revert back not needed changes
1 parent 0ecc548 commit faf2cf4

File tree

1 file changed

+9
-19
lines changed

1 file changed

+9
-19
lines changed

services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/services/background_task_periodic_heartbeat_check.py

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -48,16 +48,16 @@ async def _check_service_heartbeat(
4848
modified_at
4949
< base_start_timestamp - timedelta(minutes=2)
5050
):
51-
new_missed_heartbeat_counter = missed_heartbeat_counter + 1
51+
missed_heartbeat_counter += 1
5252
if (
53-
new_missed_heartbeat_counter
53+
missed_heartbeat_counter
5454
> resource_usage_tracker_missed_heartbeat_counter_fail
5555
):
5656
# Handle unhealthy service
5757
_logger.error(
5858
"Service run id: %s is considered unhealthy and not billed. Counter %s",
5959
service_run_id,
60-
new_missed_heartbeat_counter,
60+
missed_heartbeat_counter,
6161
)
6262
await _close_unhealthy_service(
6363
db_engine, service_run_id, base_start_timestamp
@@ -66,24 +66,14 @@ async def _check_service_heartbeat(
6666
_logger.warning(
6767
"Service run id: %s missed heartbeat. Counter %s",
6868
service_run_id,
69-
new_missed_heartbeat_counter,
69+
missed_heartbeat_counter,
7070
)
71-
# Use the original last_heartbeat_at and modified_at as keys for the update
72-
# to ensure we're updating the correct record and prevent race conditions
73-
updated_service = (
74-
await service_runs_db.update_service_missed_heartbeat_counter(
75-
db_engine,
76-
service_run_id=service_run_id,
77-
last_heartbeat_at=last_heartbeat_at,
78-
missed_heartbeat_counter=new_missed_heartbeat_counter,
79-
)
71+
await service_runs_db.update_service_missed_heartbeat_counter(
72+
db_engine,
73+
service_run_id=service_run_id,
74+
last_heartbeat_at=last_heartbeat_at,
75+
missed_heartbeat_counter=missed_heartbeat_counter,
8076
)
81-
# If the update returned None, it means another process already updated this record
82-
if updated_service is None:
83-
_logger.warning(
84-
"Service run id: %s was already updated by another process",
85-
service_run_id,
86-
)
8777

8878

8979
async def _close_unhealthy_service(

0 commit comments

Comments
 (0)