Skip to content

Commit fbdfe63

Browse files
authored
Added some fallback icons for apple devices (#6351)
1 parent 1692f4b commit fbdfe63

File tree

12 files changed

+12
-66
lines changed

12 files changed

+12
-66
lines changed

β€Žservices/static-webserver/client/source/class/osparc/Application.jsβ€Ž

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ qx.Class.define("osparc.Application", {
243243
});
244244
}
245245
if (maskIconMeta) {
246-
const maskIcon = osparc.product.Utils.getManifestIconUrl("safari-pinned-tab.svg")
246+
const maskIcon = osparc.product.Utils.getManifestIconUrl("safari-pinned-tab.png", "apple-icon-fallback.png")
247247
Promise.resolve(maskIcon)
248248
.then(resolvedUrl => {
249249
// Create the manifest data object with resolved URLs
@@ -268,15 +268,15 @@ qx.Class.define("osparc.Application", {
268268
__updateAppIcons: function() {
269269
// Array of promises to resolve icon URLs for Apple Touch Icons
270270
const appleIconUrls = [
271-
osparc.product.Utils.getManifestIconUrl("apple-icon-57x57.png"),
272-
osparc.product.Utils.getManifestIconUrl("apple-icon-60x60.png"),
273-
osparc.product.Utils.getManifestIconUrl("apple-icon-72x72.png"),
274-
osparc.product.Utils.getManifestIconUrl("apple-icon-76x76.png"),
275-
osparc.product.Utils.getManifestIconUrl("apple-icon-114x114.png"),
276-
osparc.product.Utils.getManifestIconUrl("apple-icon-120x120.png"),
277-
osparc.product.Utils.getManifestIconUrl("apple-icon-144x144.png"),
278-
osparc.product.Utils.getManifestIconUrl("apple-icon-152x152.png"),
279-
osparc.product.Utils.getManifestIconUrl("apple-icon-180x180.png")
271+
osparc.product.Utils.getManifestIconUrl("apple-icon-57x57.png", "apple-icon-fallback.png"),
272+
osparc.product.Utils.getManifestIconUrl("apple-icon-60x60.png", "apple-icon-fallback.png"),
273+
osparc.product.Utils.getManifestIconUrl("apple-icon-72x72.png", "apple-icon-fallback.png"),
274+
osparc.product.Utils.getManifestIconUrl("apple-icon-76x76.png", "apple-icon-fallback.png"),
275+
osparc.product.Utils.getManifestIconUrl("apple-icon-114x114.png", "apple-icon-fallback.png"),
276+
osparc.product.Utils.getManifestIconUrl("apple-icon-120x120.png", "apple-icon-fallback.png"),
277+
osparc.product.Utils.getManifestIconUrl("apple-icon-144x144.png", "apple-icon-fallback.png"),
278+
osparc.product.Utils.getManifestIconUrl("apple-icon-152x152.png", "apple-icon-fallback.png"),
279+
osparc.product.Utils.getManifestIconUrl("apple-icon-180x180.png", "apple-icon-fallback.png")
280280
];
281281

282282
// Array of promises to resolve icon URLs for Favicons

β€Žservices/static-webserver/client/source/class/osparc/product/Utils.jsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,15 @@ qx.Class.define("osparc.product.Utils", {
131131
});
132132
},
133133

134-
getManifestIconUrl: function(icon) {
134+
getManifestIconUrl: function(icon, fbIcon = "favicon-osparc.png") {
135135
let productName = osparc.product.Utils.getProductName();
136136
if (this.isS4LProduct() || this.isProduct("s4llite")) {
137137
productName = "s4l";
138138
} else if (this.isProduct("tis") || this.isProduct("tiplite")) {
139139
productName = "tis";
140140
}
141141
const iconPath = `https://raw.githubusercontent.com/ZurichMedTech/s4l-assets/main/app/favicons/${productName}/icons/${icon}`;
142-
const fallbackIcon = `/resource/osparc/${productName}/favicon-96x96.png`;
142+
const fallbackIcon = `/resource/osparc/${fbIcon}`;
143143
return this.__linkExists(iconPath)
144144
.then(() => iconPath)
145145
.catch(() => fallbackIcon);
25.3 KB
Loading

β€Žservices/static-webserver/client/source/resource/osparc/osparc/safari-pinned-tab.svgβ€Ž

Lines changed: 0 additions & 15 deletions
This file was deleted.
15.2 KB
Loading

β€Žservices/static-webserver/client/source/resource/osparc/s4l/safari-pinned-tab.svgβ€Ž

Lines changed: 0 additions & 24 deletions
This file was deleted.
18.9 KB
Loading
375 Bytes
Loading
618 Bytes
Loading
1.4 KB
Loading

0 commit comments

Comments
Β (0)