rename

Author: pcrespov

packages/postgres-database/src/simcore_postgres_database/utils_repos.py

@@ -8,7 +8,7 @@
 
 
 @asynccontextmanager
-async def get_or_create_connection(
+async def pass_or_acquire_connection(
     engine: AsyncEngine, connection: AsyncConnection | None = None
 ) -> AsyncIterator[AsyncConnection]:
     # NOTE: When connection is passed, the engine is actually not needed
@@ -30,7 +30,7 @@ async def get_or_create_connection(
 async def transaction_context(
     engine: AsyncEngine, connection: AsyncConnection | None = None
 ):
-    async with get_or_create_connection(engine, connection) as conn:
+    async with pass_or_acquire_connection(engine, connection) as conn:
         if conn.in_transaction():
             async with conn.begin_nested():  # inner transaction (savepoint)
                 yield conn

packages/postgres-database/tests/test_utils_repos.py

@@ -10,7 +10,7 @@
 import sqlalchemy as sa
 from simcore_postgres_database.models.tags import tags
 from simcore_postgres_database.utils_repos import (
-    get_or_create_connection,
+    pass_or_acquire_connection,
     transaction_context,
 )
 from sqlalchemy.exc import IntegrityError
@@ -100,7 +100,7 @@ async def get_by_id(
         *,
         row_id: int,
     ) -> dict[str, Any] | None:
-        async with get_or_create_connection(self.engine, connection) as conn:
+        async with pass_or_acquire_connection(self.engine, connection) as conn:
             result = await conn.execute(
                 sa.select(self.table).where(self.table.c.id == row_id)
             )
@@ -114,7 +114,7 @@ async def get_page(
         limit: int,
         offset: int = 0,
     ) -> _PageTuple:
-        async with get_or_create_connection(self.engine, connection) as conn:
+        async with pass_or_acquire_connection(self.engine, connection) as conn:
             # Compute total count
             total_count_query = sa.select(sa.func.count()).select_from(self.table)
             total_count_result = await conn.execute(total_count_query)