@GitHK review: drop id col

Author: pcrespov

packages/postgres-database/src/simcore_postgres_database/migration/versions/48604dfdc5f4_new_projects_to_job_map.py

@@ -20,7 +20,6 @@ def upgrade():
     # ### commands auto generated by Alembic - please adjust! ###
     op.create_table(
         "projects_to_jobs",
-        sa.Column("id", sa.BigInteger(), autoincrement=True, nullable=False),
         sa.Column("project_uuid", sa.String(), nullable=False),
         sa.Column(
             "job_parent_resource_name",

packages/postgres-database/src/simcore_postgres_database/models/projects_to_jobs.py

@@ -8,13 +8,6 @@
     # Maps projects used as jobs in the public-api
     "projects_to_jobs",
     metadata,
-    sa.Column(
-        "id",
-        sa.BigInteger,
-        primary_key=True,
-        autoincrement=True,
-        doc="Identifier index",
-    ),
     sa.Column(
         "project_uuid",
         sa.String,
@@ -35,6 +28,7 @@
         "the relative resource name is shelves/shelf1/jobs/job2, "
         "the parent resource name is shelves/shelf1.",
     ),
+    # Composite key (project_uuid, job_parent_resource_name) uniquely identifies very row
     sa.UniqueConstraint(
         "project_uuid",
         "job_parent_resource_name",

services/web/server/src/simcore_service_webserver/projects/_jobs_repository.py

@@ -1,7 +1,6 @@
 import logging
 
 from models_library.projects import ProjectID
-from pydantic import PositiveInt
 from simcore_postgres_database.models.projects_to_jobs import projects_to_jobs
 from simcore_postgres_database.utils_repos import transaction_context
 from sqlalchemy.dialects.postgresql import insert as pg_insert
@@ -20,7 +19,7 @@ async def set_project_as_job(
         *,
         project_uuid: ProjectID,
         job_parent_resource_name: str,
-    ) -> PositiveInt:
+    ) -> None:
         async with transaction_context(self.engine, connection) as conn:
             stmt = (
                 pg_insert(projects_to_jobs)
@@ -32,10 +31,6 @@ async def set_project_as_job(
                     index_elements=["project_uuid", "job_parent_resource_name"],
                     set_={"job_parent_resource_name": job_parent_resource_name},
                 )
-                .returning(projects_to_jobs.c.id)
             )
 
-            result = await conn.execute(stmt)
-            row = result.one()
-            projects_to_jobs_id: PositiveInt = row.id
-            return projects_to_jobs_id
+            await conn.execute(stmt)

services/web/server/src/simcore_service_webserver/projects/_jobs_service.py

@@ -42,7 +42,6 @@ async def set_project_as_job(
 
     repo = ProjectJobsRepository.create_from_app(app)
 
-    projects_to_jobs_id = await repo.set_project_as_job(
+    await repo.set_project_as_job(
         project_uuid=project_uuid, job_parent_resource_name=job_parent_resource_name
     )
-    assert projects_to_jobs_id  # nosec