fixed broken tests

Author: Andrei Neagu

services/web/server/src/simcore_service_webserver/users/_schemas.py

@@ -19,13 +19,13 @@ class UserProfile(OutputSchema):
     first_name: str | None
     last_name: str | None
     email: LowerCaseEmailStr
-    institution: str | None
+    institution: str | None = None
     phone: str | None
-    address: str | None
-    city: str | None
-    state: str | None = Field(description="State, province, canton, ...")
-    postal_code: str | None
-    country: str | None
+    address: str | None = None
+    city: str | None = None
+    state: str | None = Field(None, description="State, province, canton, ...")
+    postal_code: str | None = None
+    country: str | None = None
     extras: dict[str, Any] = Field(
         default_factory=dict,
         description="Keeps extra information provided in the request form",
@@ -36,7 +36,7 @@ class UserProfile(OutputSchema):
 
     # user status
     registered: bool
-    status: UserStatus | None
+    status: UserStatus | None = None
     products: list[ProductName] | None = Field(
         default=None,
         description="List of products this users is included or None if fields is unset",

services/web/server/src/simcore_service_webserver/version_control/_handlers.py

@@ -238,6 +238,8 @@ async def _update_checkpoint_annotations_handler(request: web.Request):
     path_params = parse_request_path_parameters_as(_CheckpointsPathParam, request)
     update = await parse_request_body_as(CheckpointAnnotations, request)
 
+    assert isinstance(path_params.ref_id, int)
+
     checkpoint: Checkpoint = await update_checkpoint(
         vc_repo,
         project_uuid=path_params.project_uuid,

services/web/server/src/simcore_service_webserver/version_control/models.py

@@ -1,11 +1,19 @@
 from datetime import datetime
-from typing import Any, TypeAlias, Union
+from typing import Annotated, Any, TypeAlias, Union
 
 from aiopg.sa.result import RowProxy
 from models_library.basic_types import SHA1Str
 from models_library.projects import ProjectID
 from models_library.projects_nodes import Node
-from pydantic import ConfigDict, BaseModel, Field, PositiveInt, StrictBool, StrictFloat, StrictInt
+from pydantic import (
+    BaseModel,
+    ConfigDict,
+    Field,
+    PositiveInt,
+    StrictBool,
+    StrictFloat,
+    StrictInt,
+)
 from pydantic.networks import HttpUrl
 
 BuiltinTypes: TypeAlias = Union[StrictBool, StrictInt, StrictFloat, str]
@@ -24,7 +32,7 @@
 
 CommitID: TypeAlias = int
 BranchID: TypeAlias = int
-RefID: TypeAlias = CommitID | str
+RefID: TypeAlias = Annotated[CommitID | str, Field(union_mode="left_to_right")]
 
 CheckpointID: TypeAlias = PositiveInt
 
@@ -51,6 +59,7 @@ def from_commit_log(cls, commit: RowProxy, tags: list[RowProxy]) -> "Checkpoint"
 
 class WorkbenchView(BaseModel):
     """A view (i.e. read-only and visual) of the project's workbench"""
+
     model_config = ConfigDict(from_attributes=True)
 
     # NOTE: Tmp replacing UUIDS by str due to a problem serializing to json UUID keys

services/web/server/tests/unit/with_dbs/03/version_control/test_version_control_handlers.py

@@ -121,8 +121,8 @@ async def test_workflow(
     )
 
     assert CheckpointApiModel.model_validate(page.data[0]) == checkpoint1
-
     # UPDATE checkpoint annotations
+    # here is the issue
     resp = await client.patch(
         f"/{VX}/repos/projects/{project_uuid}/checkpoints/{checkpoint1.id}",
         json={"message": "updated message", "tag": "Version 1"},