copilot

Author: Andrei Neagu

packages/pytest-simcore/src/pytest_simcore/long_running_tasks.py

@@ -20,7 +20,7 @@ async def wrapper(*func_args, **func_kwargs):
 
 
 @pytest.fixture
-def uese_in_memory_lonng_running_tasks(mocker: MockerFixture) -> None:
+def use_in_memory_long_running_tasks(mocker: MockerFixture) -> None:
     mocker.patch.object(task, "RedisStore", InMemoryStore)
     # for testing the exclsive is not required so it's disabled
     mocker.patch.object(task, "exclusive", _mock_decorator_with_args)

packages/service-library/src/servicelib/redis/_client.py

@@ -59,7 +59,6 @@ def __post_init__(self) -> None:
             decode_responses=self.decode_responses,
             client_name=self.client_name,
         )
-        # NOTE: connection is done here already
         self._is_healthy = False
         self._health_check_task_started_event = asyncio.Event()
 
@@ -78,7 +77,7 @@ async def _periodic_check_health() -> None:
         # NOTE: this achieves 2 very important things:
         # - ensure redis is working
         # - before shutting down an initialized Redis connection it must
-        #   make at least one call to the servicer, otherwise tests might hang
+        #   make at least one call to the server, otherwise tests might hang
         await self.ping()
 
         _logger.info(

packages/service-library/tests/deferred_tasks/test__base_deferred_handler.py

@@ -43,7 +43,7 @@ class MockKeys(StrAutoEnum):
     GET_TIMEOUT = auto()
     START_DEFERRED = auto()
     ON_DEFERRED_CREATED = auto()
-    RUN_DEFERRED_BEFORE_HADNLER = auto()
+    RUN_DEFERRED_BEFORE_HANDLER = auto()
     RUN_DEFERRED_AFTER_HANDLER = auto()
     ON_DEFERRED_RESULT = auto()
     ON_FINISHED_WITH_ERROR = auto()
@@ -124,7 +124,7 @@ async def on_created(
 
             @classmethod
             async def run(cls, context: DeferredContext) -> Any:
-                mocks[MockKeys.RUN_DEFERRED_BEFORE_HADNLER](context)
+                mocks[MockKeys.RUN_DEFERRED_BEFORE_HANDLER](context)
                 result = await run(context)
                 mocks[MockKeys.RUN_DEFERRED_AFTER_HANDLER](context)
                 return result
@@ -322,7 +322,7 @@ async def _run_to_cancel(_: DeferredContext) -> None:
     await _assert_mock_call(mocks, key=MockKeys.ON_DEFERRED_CREATED, count=1)
     task_uid = TaskUID(mocks[MockKeys.ON_DEFERRED_CREATED].call_args_list[0].args[0])
 
-    await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED_BEFORE_HADNLER, count=1)
+    await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED_BEFORE_HANDLER, count=1)
     await mocked_deferred_handler.cancel(task_uid)
 
     await _assert_mock_call(mocks, key=MockKeys.ON_FINISHED_WITH_ERROR, count=0)

services/director-v2/tests/unit/test_api_route_dynamic_scheduler.py

@@ -27,7 +27,7 @@
 
 @pytest.fixture
 def mock_env(
-    uese_in_memory_lonng_running_tasks: None,
+    use_in_memory_long_running_tasks: None,
     mock_exclusive: None,
     disable_rabbitmq: None,
     disable_postgres: None,

services/director-v2/tests/unit/test_modules_dynamic_sidecar_scheduler.py

@@ -124,7 +124,7 @@ async def _assert_get_dynamic_services_mocked(
 
 @pytest.fixture
 def mock_env(
-    uese_in_memory_lonng_running_tasks: None,
+    use_in_memory_long_running_tasks: None,
     mock_exclusive: None,
     disable_postgres: None,
     disable_rabbitmq: None,

services/director-v2/tests/unit/test_modules_dynamic_sidecar_scheduler_task.py

@@ -43,7 +43,7 @@
 
 @pytest.fixture
 def mock_env(
-    uese_in_memory_lonng_running_tasks: None,
+    use_in_memory_long_running_tasks: None,
     disable_postgres: None,
     disable_rabbitmq: None,
     mock_env: EnvVarsDict,

services/dynamic-sidecar/tests/conftest.py

@@ -169,7 +169,7 @@ def mock_rabbit_check(mocker: MockerFixture) -> None:
 
 @pytest.fixture
 def base_mock_envs(
-    uese_in_memory_lonng_running_tasks: None,
+    use_in_memory_long_running_tasks: None,
     dy_volumes: Path,
     shared_store_dir: Path,
     compose_namespace: str,
@@ -211,7 +211,7 @@ def base_mock_envs(
 
 @pytest.fixture
 def mock_environment(
-    uese_in_memory_lonng_running_tasks: None,
+    use_in_memory_long_running_tasks: None,
     mock_storage_check: None,
     mock_postgres_check: None,
     mock_rabbit_check: None,

services/storage/src/simcore_service_storage/modules/long_running_tasks.py

@@ -7,7 +7,7 @@
 from .._meta import API_VTAG
 from ..core.settings import ApplicationSettings
 
-_LONG_RUNNING_TASKS_NAESPACE: Final[Namespace] = "storage"
+_LONG_RUNNING_TASKS_NAMESPACE: Final[Namespace] = "storage"
 
 
 def setup_rest_api_long_running_tasks_for_uploads(app: FastAPI) -> None:
@@ -16,5 +16,5 @@ def setup_rest_api_long_running_tasks_for_uploads(app: FastAPI) -> None:
         app,
         router_prefix=f"/{API_VTAG}/futures",
         redis_settings=settings.STORAGE_REDIS,
-        namespace=_LONG_RUNNING_TASKS_NAESPACE,
+        namespace=_LONG_RUNNING_TASKS_NAMESPACE,
     )