@pcrespov review: use ProductName

Author: sanderegg

packages/pytest-simcore/src/pytest_simcore/docker_compose.py

@@ -392,6 +392,7 @@ def _filter_services_and_dump(
             service["environment"] = _minio_fix(service["environment"])
 
         if name == "postgres":
+            # NOTE: # -c fsync=off is not recommended for production as this disable writing to disk https://pythonspeed.com/articles/faster-db-tests/
             service["command"] += ["-c", "fsync=off"]
 
     # updates current docker-compose (also versioned ... do not change by hand)

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/storage/paths.py

@@ -5,6 +5,7 @@
     AsyncJobNameData,
 )
 from models_library.api_schemas_storage import STORAGE_RPC_NAMESPACE
+from models_library.products import ProductName
 from models_library.projects_nodes_io import LocationID
 from models_library.rabbitmq_basic_types import RPCMethodName
 from models_library.users import UserID
@@ -17,7 +18,7 @@ async def compute_path_size(
     client: RabbitMQRPCClient,
     *,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     location_id: LocationID,
     path: Path,
 ) -> tuple[AsyncJobGet, AsyncJobNameData]:

services/storage/tests/unit/test_rpc_handlers_paths.py

@@ -21,6 +21,7 @@
     AsyncJobResult,
 )
 from models_library.api_schemas_storage import STORAGE_RPC_NAMESPACE
+from models_library.products import ProductName
 from models_library.projects_nodes_io import LocationID, NodeID, SimcoreS3FileID
 from models_library.rabbitmq_basic_types import RPCMethodName
 from models_library.users import UserID
@@ -61,7 +62,7 @@ async def _assert_compute_path_size(
     storage_rpc_client: RabbitMQRPCClient,
     location_id: LocationID,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     *,
     path: Path,
     expected_total_size: int,
@@ -119,7 +120,7 @@ async def test_path_compute_size(
         dict[NodeID, dict[SimcoreS3FileID, FileIDDict]],
     ],
     project_params: ProjectWithFilesParams,
-    product_name: str,
+    product_name: ProductName,
 ):
     assert (
         len(project_params.allowed_file_sizes) == 1
@@ -235,7 +236,7 @@ async def test_path_compute_size_inexistent_path(
     user_id: UserID,
     faker: Faker,
     fake_datcore_tokens: tuple[str, str],
-    product_name: str,
+    product_name: ProductName,
 ):
     await _assert_compute_path_size(
         storage_rabbitmq_rpc_client,

services/storage/tests/unit/test_rpc_handlers_simcore_s3.py

@@ -29,6 +29,7 @@
     FoldersBody,
 )
 from models_library.basic_types import SHA256Str
+from models_library.products import ProductName
 from models_library.projects_nodes_io import NodeID, NodeIDStr, SimcoreS3FileID
 from models_library.users import UserID
 from pydantic import ByteSize, TypeAdapter
@@ -62,7 +63,7 @@
 async def _request_copy_folders(
     rpc_client: RabbitMQRPCClient,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     source_project: dict[str, Any],
     dst_project: dict[str, Any],
     nodes_map: dict[NodeID, NodeID],
@@ -103,7 +104,7 @@ async def test_copy_folders_from_non_existing_project(
     initialized_app: FastAPI,
     storage_rabbitmq_rpc_client: RabbitMQRPCClient,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     create_project: Callable[..., Awaitable[dict[str, Any]]],
     faker: Faker,
 ):
@@ -143,7 +144,7 @@ async def test_copy_folders_from_empty_project(
     initialized_app: FastAPI,
     storage_rabbitmq_rpc_client: RabbitMQRPCClient,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     create_project: Callable[[], Awaitable[dict[str, Any]]],
     sqlalchemy_async_engine: AsyncEngine,
     storage_s3_client: SimcoreS3API,
@@ -204,7 +205,7 @@ async def test_copy_folders_from_valid_project_with_one_large_file(
     short_dsm_cleaner_interval: int,
     storage_rabbitmq_rpc_client: RabbitMQRPCClient,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     create_project: Callable[[], Awaitable[dict[str, Any]]],
     sqlalchemy_async_engine: AsyncEngine,
     random_project_with_files: Callable[
@@ -297,7 +298,7 @@ async def test_copy_folders_from_valid_project(
     initialized_app: FastAPI,
     storage_rabbitmq_rpc_client: RabbitMQRPCClient,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     create_project: Callable[[], Awaitable[dict[str, Any]]],
     sqlalchemy_async_engine: AsyncEngine,
     random_project_with_files: Callable[
@@ -358,7 +359,7 @@ async def _create_and_delete_folders_from_project(
     rpc_client: RabbitMQRPCClient,
     client: httpx.AsyncClient,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     project: dict[str, Any],
     initialized_app: FastAPI,
     project_db_creator: Callable,
@@ -472,7 +473,7 @@ async def test_create_and_delete_folders_from_project(
     storage_rabbitmq_rpc_client: RabbitMQRPCClient,
     client: httpx.AsyncClient,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     with_random_project_with_files: tuple[
         dict[str, Any],
         dict[NodeID, dict[SimcoreS3FileID, dict[str, Path | str]]],

services/web/server/src/simcore_service_webserver/projects/_crud_api_create.py

@@ -8,6 +8,7 @@
 from jsonschema import ValidationError as JsonSchemaValidationError
 from models_library.api_schemas_long_running_tasks.base import ProgressPercent
 from models_library.api_schemas_webserver.projects import ProjectGet
+from models_library.products import ProductName
 from models_library.projects import ProjectID
 from models_library.projects_access import Owner
 from models_library.projects_nodes_io import NodeID
@@ -71,7 +72,7 @@ async def _prepare_project_copy(
     app: web.Application,
     *,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
     src_project_uuid: ProjectID,
     as_template: bool,
     deep_copy: bool,

services/web/server/src/simcore_service_webserver/storage/api.py

@@ -17,6 +17,7 @@
     PresignedLink,
 )
 from models_library.generics import Envelope
+from models_library.products import ProductName
 from models_library.projects import ProjectID
 from models_library.projects_nodes_io import LocationID, NodeID, SimCoreFileLink
 from models_library.users import UserID
@@ -108,7 +109,7 @@ async def copy_data_folders_from_project(
     destination_project: ProjectDict,
     nodes_map: NodesMap,
     user_id: UserID,
-    product_name: str,
+    product_name: ProductName,
 ) -> AsyncGenerator[AsyncJobComposedResult, None]:
     with log_context(_logger, logging.DEBUG, msg=f"copy {nodes_map=}"):
         rabbitmq_client = get_rabbitmq_rpc_client(app)