-
Notifications
You must be signed in to change notification settings - Fork 32
Closed
Closed
Copy link
Labels
bugbuggy, it does not work as expectedbuggy, it does not work as expected
Description
Is there an existing issue for this?
- I have searched the existing issues
Which deploy/s?
No response
Current Behavior
Pylint complains with a bunch of E1123: Unexpected keyword argument errors when invoking the constructor of custom errors:
Linting /home/runner/work/osparc-simcore/osparc-simcore/services/dynamic-sidecar
Using config file /home/runner/work/osparc-simcore/osparc-simcore/.pylintrc
************* Module simcore_service_dynamic_sidecar.modules.container_utils
src/simcore_service_dynamic_sidecar/modules/container_utils.py:41:18: E1123: Unexpected keyword argument 'command' in constructor call (unexpected-keyword-arg)
src/simcore_service_dynamic_sidecar/modules/container_utils.py:41:18: E1123: Unexpected keyword argument 'exit_code' in constructor call (unexpected-keyword-arg)
src/simcore_service_dynamic_sidecar/modules/container_utils.py:41:18: E1123: Unexpected keyword argument 'command_result' in constructor call (unexpected-keyword-arg)
src/simcore_service_dynamic_sidecar/modules/container_utils.py:41:18: E1120: No value for argument 'nessage' in constructor call (no-value-for-parameter)
src/simcore_service_dynamic_sidecar/modules/container_utils.py:81:18: E1123: Unexpected keyword argument 'container_name' in constructor call (unexpected-keyword-arg)
src/simcore_service_dynamic_sidecar/modules/container_utils.py:81:18: E1120: No value for argument 'nessage' in constructor call (no-value-for-parameter)
src/simcore_service_dynamic_sidecar/modules/container_utils.py:86:14: E1123: Unexpected keyword argument 'timeout' in constructor call (unexpected-keyword-arg)
src/simcore_service_dynamic_sidecar/modules/container_utils.py:86:14: E1123: Unexpected keyword argument 'command' in constructor call (unexpected-keyword-arg)
src/simcore_service_dynamic_sidecar/modules/container_utils.py:86:14: E1120: No value for argument 'nessage' in constructor call (no-value-for-parameter)
----------------------------------------------------------------------
Your code has been rated at 9.92/10
Checked 122 files, skipped 0 files
The issues seems in the errors hierarchy and conflicts with init method.
- partially fixes: ♻️ Greenify pylint (after Pydantic v2 migration) #6747
Expected Behavior
No errors.
Steps To Reproduce
cd services/dynamic-services
make pylint
Anything else?
No response
Metadata
Metadata
Labels
bugbuggy, it does not work as expectedbuggy, it does not work as expected