Skip to content

Uniform the timedelta format in ENV vars #6791

@giancarloromeo

Description

@giancarloromeo

Context & Motivation

Pydantic v2 changed the accepted str format for datetime and timedelta (compared to v1).

Current status

In ENV vars, timings have different formats and sometimes, without knowing the implementation, it's not easy to understand if we are talking about seconds, mins, hours or days from simple scalar numbers.

Action

Uniform all the intervals, timeouts etc. to a standard format.

Legenda:

🚨 BREAKING CHANGE
⚠️ WARNING

DYNAMIC_SIDECAR_API_SAVE_RESTORE_STATE_TIMEOUT 🚨

After migration to Pydantic v2, it's a dt.timedelta instead of PositiveInt.

Ops-Config

PROJECTS_INACTIVITY_INTERVAL ⚠️

Currently, the ENV var represents seconds and is implicitily validated against timedelta but with a warning.

Ops-Config:

### ENV vars that need changes
- [x] `DYNAMIC_SIDECAR_API_SAVE_RESTORE_STATE_TIMEOUT` included in #6578
- [ ] https://github.com/ITISFoundation/osparc-simcore/pull/6797
- [ ] https://github.com/ITISFoundation/osparc-simcore/pull/6812

Metadata

Metadata

Labels

t:maintenanceSome planned maintenance work

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions