Skip to content

Review workflows to mock env-vars including external env-file optionย #7929

@pcrespov

Description

@pcrespov

Follow-Up Work Required from #7919

To complete the unification:

  • โœ… Standardize fixture names used for mocking environment variables
  • โœ… Harmonize mocking workflows, which currently vary:
    • Some use .env-devel filtered via docker-compose.ymlโ€™s environment section
    • Others rely on different or inconsistent methods
  • Unify usage of external_envfile_dict: will allow to run tests against configurations in deploys
    • Refactor so that it has to be explicitly enabled in the test that we want to use it, instead of as a generic fixture (which might have unexpected and bad consequences)

This can be a very DANGEROUS feature and I would like to be sure that it is clear with every dev that this can affect the deployments depending on what test(s) are being run. Otherwise I like that it is made simpler. but ideally we should prevent tests that are not only read-only...

Originally posted by @sanderegg in #7919 (review)

Metadata

Metadata

Labels

t:maintenanceSome planned maintenance work

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions