🐛 Fixed Redis issue where keys ended up in the wrong deployment. #6368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
changed the title
giancarloromeo
approved these changes
Sep 16, 2024
sanderegg
approved these changes
Sep 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6368 +/- ##
=========================================
+ Coverage 84.5% 88.7% +4.1%
=========================================
Files 10 1075 +1065
Lines 214 47411 +47197
Branches 25 356 +331
=========================================
+ Hits 181 42090 +41909
- Misses 23 5252 +5229
- Partials 10 69 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
After the upgrade of python
3.11enums work a bit differently.class X(int, Enum)andclass X(IntEnum)work differently when serialising them in a string. To maintain the same behaviour it is required to use theIntEnumPrevious serialisation
redis://:***@redis:6379/RedisDatabase.ANNOUNCEMENTS-> current fixed oneredis://:***@redis:6379/5Related issue/s
How to test
Dev-ops checklist