Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Sep 20, 2024

What do these changes do?

Changes log level for the garbage_collector to be set to INFO regardless of the global flag

Question: Why not put the log level to debug? this never works, tried it multiple times and it always somehow reverts back to something else.

As a developer, when trying to answer users' questions like: Why has my service closed? I want to quickly and reliably check the logs and figure out if their project was closed by the GC.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Sep 20, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Sep 20, 2024
@GitHK GitHK marked this pull request as ready for review September 20, 2024 08:10
@codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.9%. Comparing base (cafbf96) to head (0505eba).
Report is 572 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6403      +/-   ##
=========================================
+ Coverage    84.5%   87.9%    +3.3%     
=========================================
  Files          10    1172    +1162     
  Lines         214   51692   +51478     
  Branches       25     930     +905     
=========================================
+ Hits          181   45452   +45271     
- Misses         23    6065    +6042     
- Partials       10     175     +165     
Flag Coverage Δ
integrationtests 64.6% <80.0%> (?)
unittests 85.4% <87.5%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/service-library/src/servicelib/logging_utils.py 76.1% <100.0%> (ø)
..._webserver/garbage_collector/_core_disconnected.py 82.2% <100.0%> (ø)
...core_service_webserver/garbage_collector/plugin.py 100.0% <100.0%> (ø)

... and 1179 files with indirect coverage changes

@pcrespov
Copy link
Member

Question: Why not put the log level to debug? this never works, tried it multiple times and it always somehow reverts back to something else.

As a developer, when trying to answer users' questions like: Why has my service closed? I want to quickly and reliably check the logs and figure out if their project was closed by the GC.

I would like to follow up a bit with you on this. IMO the GC services in similar in many ways to the autoscaler service in the sense that it observes to get a state and acts on it. There @sanderegg used several techniques to monitor the activity of the service by combining informative logs with prometheus metrics.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@GitHK GitHK requested a review from pcrespov September 23, 2024 08:15
@GitHK GitHK requested a review from pcrespov September 23, 2024 11:53
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are not using correctly caplog. See the example i attach
Take advantage and add more informative logs

@GitHK GitHK enabled auto-merge (squash) September 23, 2024 14:24
@sonarqubecloud
Copy link

@GitHK GitHK merged commit 28c8ee5 into ITISFoundation:master Sep 24, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-warn-gc-service-shutdown branch September 24, 2024 06:26
matusdrobuliak66 pushed a commit that referenced this pull request Sep 25, 2024
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Sep 25, 2024
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants