Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Sep 20, 2024

What do these changes do?

  • 🎨 The user can remove themselves from the project/workspace.

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 20, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the MartinKippenberger milestone Sep 20, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 20, 2024 14:08
@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 user can remove itself from project/workspace 🎨 The user can remove themselves from the project/workspace. Sep 20, 2024
@codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.8%. Comparing base (cafbf96) to head (b2d2fd9).
Report is 573 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6415      +/-   ##
=========================================
- Coverage    84.5%   78.8%    -5.8%     
=========================================
  Files          10     595     +585     
  Lines         214   30418   +30204     
  Branches       25     260     +235     
=========================================
+ Hits          181   23975   +23794     
- Misses         23    6383    +6360     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.7% <0.0%> (?)
unittests 81.2% <100.0%> (-3.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../simcore_service_webserver/projects/_groups_api.py 91.3% <100.0%> (ø)
...imcore_service_webserver/workspaces/_groups_api.py 81.8% <100.0%> (ø)

... and 603 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's cool, but a few tests might be a good idea to add.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 23, 2024 15:43
@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 The user can remove themselves from the project/workspace. 🎨 The user can remove themselves from the project/workspace. 🚨 Sep 23, 2024
@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 24dc16e into ITISFoundation:master Sep 24, 2024
57 checks passed
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Sep 25, 2024
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants