🐛 Improved Error Handling for Missing Billing Details #6418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
requested review from
GitHK,
matusdrobuliak66 and
sanderegg
as code owners
pcrespov
added
the
a:webserver
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6418 +/- ##
=========================================
+ Coverage 84.5% 90.2% +5.6%
=========================================
Files 10 1178 +1168
Lines 214 51803 +51589
Branches 25 865 +840
=========================================
+ Hits 181 46734 +46553
- Misses 23 4938 +4915
- Partials 10 131 +121
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
force-pushed
the
fix/errors-payments
branch
from
dc0d090 to
7daf755
Compare
|
odeimaiz
approved these changes
Sep 20, 2024
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Oct 2, 2024
16 tasks
This was referenced Oct 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Improved Error Handling for Missing Pre-registration and Billing Details**
Previously, when account setup was incomplete or pre-registration information (such as billing country) was missing, the payment process would fail raising an 500 that displayed confusing message in the front-end (should be address in #5487). This was due to the REST handlers not properly addressing the absence of required billing details.
With this update, the service now responds with
HTTP_503_SERVICE_UNAVAILABLEand an explicit message indicating that the payment service is unavailable until the necessary billing details are provided. Currently, these details can only be supplied on the service side (filling theuser_pre_registrationtable).Additionally, errors related to missing billing information are now logged with an
OECcode and relevant debug data, making them easier to trace in the logs or use as triggers for alerts.Related issue/s
How to test
Dev-ops checklist