Skip to content

🎨 improve DB foreign key dependencies (πŸ—ƒοΈ) #6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 24, 2024
Merged

🎨 improve DB foreign key dependencies (πŸ—ƒοΈ) #6428

merged 7 commits into from
Sep 24, 2024

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Sep 24, 2024 •
edited
Loading

What do these changes do?

  • 🎨 improve DB foreign key dependencies (πŸ—ƒοΈ)
    • In several tables, foreign keys were missing where they should have been. Including them makes the database less error-prone, especially when performing manual changes (e.g., during TIP migration).

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 24, 2024 07:06
@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 24, 2024
@codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 89.2%. Comparing base (cafbf96) to head (c7e083b).
Report is 575 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6428      +/-   ##
=========================================
+ Coverage    84.5%   89.2%    +4.6%     
=========================================
  Files          10    1299    +1289     
  Lines         214   54675   +54461     
  Branches       25     943     +918     
=========================================
+ Hits          181   48802   +48621     
- Misses         23    5724    +5701     
- Partials       10     149     +139
Flag Coverage Ξ”
integrationtests 64.6% <ΓΈ> (?)
unittests 86.9% <ΓΈ> (+2.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
...models/resource_tracker_pricing_plan_to_service.py 100.0% <ΓΈ> (ΓΈ)
..._database/models/resource_tracker_pricing_plans.py 100.0% <ΓΈ> (ΓΈ)
...base/models/resource_tracker_pricing_unit_costs.py 100.0% <ΓΈ> (ΓΈ)
...se/src/simcore_postgres_database/models/wallets.py 100.0% <ΓΈ> (ΓΈ)
...src/simcore_postgres_database/models/workspaces.py 100.0% <ΓΈ> (ΓΈ)

... and 1260 files with indirect coverage changes

pcrespov
pcrespov approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's do these cleanups on step at a time
NOTE: on doc, let's try to add some non-redundant info. I would like to feed these schemas to an LLM and this doc would be more valuable if they describe something that is not already defined in the schema

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 24, 2024 08:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Sep 24, 2024
odeimaiz
odeimaiz reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’ͺ

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 24, 2024 11:22
@odeimaiz odeimaiz self-requested a review September 24, 2024 11:33
@matusdrobuliak66 matusdrobuliak66 merged commit 1a4dcea into ITISFoundation:master Sep 24, 2024
57 checks passed
GitHK
GitHK reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is quite some code duplication in the tests, I wonder if a common fixture would have not been better.

jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Sep 25, 2024
@matusdrobuliak66 @jsaq007
🎨 improve DB foreign key dependencies (πŸ—ƒοΈ) (ITISFoundation#6428)
3fb9076
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@matusdrobuliak66 @mrnicegyu11
🎨 improve DB foreign key dependencies (πŸ—ƒοΈ) (ITISFoundation#6428)
83b3152
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 29, 2024
Closed
57 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matusdrobuliak66 @GitHK @pcrespov @odeimaiz