Skip to content

🎨 improve error handling on pricing plans #6436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 25, 2024
Merged

🎨 improve error handling on pricing plans #6436

merged 6 commits into from
Sep 25, 2024

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Sep 24, 2024

What do these changes do?

  • 🎨 improve error handling on pricing plans

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 24, 2024 14:44
@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 24, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the MartinKippenberger milestone Sep 24, 2024
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Sep 24, 2024
odeimaiz
odeimaiz reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.0%. Comparing base (cafbf96) to head (2368c0b).
Report is 586 commits behind head on master.

Files with missing lines Patch % Lines
...imcore_service_webserver/resource_usage/_client.py 72.7% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6436      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.4%     
=========================================
  Files          10     362     +352     
  Lines         214   18106   +17892     
  Branches       25       0      -25     
=========================================
+ Hits          181   15939   +15758     
- Misses         23    2167    +2144     
+ Partials       10       0      -10
Flag Coverage Δ
unittests 88.0% <85.7%> (+3.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...src/simcore_service_webserver/catalog/_handlers.py 80.3% <100.0%> (ø)
...core_service_webserver/catalog/_handlers_errors.py 86.6% <100.0%> (ø)
...core_service_webserver/projects/_nodes_handlers.py 91.2% <100.0%> (ø)
...ore_service_webserver/projects/_states_handlers.py 92.2% <100.0%> (ø)
...simcore_service_webserver/resource_usage/errors.py 100.0% <100.0%> (ø)
...imcore_service_webserver/resource_usage/_client.py 53.7% <72.7%> (ø)

... and 366 files with indirect coverage changes

pcrespov
pcrespov approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a small test that verifies that this errors are raised? You can reuse it for future tests.

You can mock e.g. the response of the catalog. There are some mocks available

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 25, 2024 15:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 merged commit ccdeff2 into ITISFoundation:master Sep 25, 2024
56 of 57 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@matusdrobuliak66 @mrnicegyu11
🎨 improve error handling on pricing plans (ITISFoundation#6436)
76e96c7
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz left review comments

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

4 participants

@matusdrobuliak66 @GitHK @pcrespov @odeimaiz