Upgrade resource usage tracker (Pydantic v2)

[giancarloromeo]

What do these changes do?

Upgrade resource usage tracker to Pydantic v2.

Related issue/s

• resolves Major upgrade to pydantic 2.0 #4481

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration@fbf9fa9). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...racker/modules/db/repositories/resource_tracker.py	93.3%	1 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6517   +/-   ##
=======================================================
  Coverage                         ?   84.9%           
=======================================================
  Files                            ?     593           
  Lines                            ?   22405           
  Branches                         ?     719           
=======================================================
  Hits                             ?   19037           
  Misses                           ?    3241           
  Partials                         ?     127           

Flag	Coverage Δ
unittests	84.9% <98.3%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...emas_resource_usage_tracker/credit_transactions.py	100.0% <100.0%> (ø)
...pi_schemas_resource_usage_tracker/pricing_plans.py	100.0% <100.0%> (ø)
...ages/settings-library/src/settings_library/base.py	89.2% <100.0%> (ø)
...rc/simcore_service_resource_usage_tracker/_meta.py	100.0% <100.0%> (ø)
...esource_usage_tracker/api/rpc/_resource_tracker.py	100.0% <ø> (ø)
...service_resource_usage_tracker/core/application.py	100.0% <100.0%> (ø)
...core_service_resource_usage_tracker/core/errors.py	100.0% <100.0%> (ø)
...re_service_resource_usage_tracker/core/settings.py	100.0% <100.0%> (ø)
...ker/models/resource_tracker_credit_transactions.py	100.0% <100.0%> (ø)
...e_tracker/models/resource_tracker_pricing_plans.py	100.0% <100.0%> (ø)
... and 7 more

[sanderegg]

just some questions about the Decimal changes.

[sanderegg]

3 questions here:

• why do we need to do that?
• is the BeforeValidator having the same behavior as the old Decimal ? (in which case I am wondering if the new Decimal is better? or not? @matusdrobuliak66 @pcrespov )
• PlainSerializer, is that when we output to json it creates a plain float? is this actually valid json?

[giancarloromeo]

The PlainSerializer is used here to serialize as float the Decimal field that from Pydantic v2 would be returned as str in the JSON serialization. Without it the OpenAPI schema would have a field of type string instead of number, changing the interface.

[matusdrobuliak66]

If unit tests are passing, then it should be fine (we have some tests for this Decimal checks)

[pcrespov]

@matusdrobuliak66 I’m quite skeptical about the changes in these Decimal ... should be test it further ?:-(

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[matusdrobuliak66]

Thanks! let me know if help is needed to fix some failing tests

[pcrespov]

👍