Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 16, 2024

What do these changes do?

  • updates all service libraries
  • fixed broken tests

Fixed after different merges the unit-tests for:

  •  efs-guardian
  •  invitations
  •  clusters-keeper

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Oct 16, 2024
@GitHK GitHK added the a:agent agent service label Oct 16, 2024
@GitHK GitHK added this to the MartinKippenberger milestone Oct 16, 2024
@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration@6906e94). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...servicelib/rabbitmq/rpc_interfaces/agent/errors.py 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6546   +/-   ##
=======================================================
  Coverage                         ?   79.8%           
=======================================================
  Files                            ?     407           
  Lines                            ?   16576           
  Branches                         ?     949           
=======================================================
  Hits                             ?   13238           
  Misses                           ?    3174           
  Partials                         ?     164           
Flag Coverage Δ
unittests 79.8% <89.4%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/agent/src/simcore_service_agent/core/settings.py 100.0% <100.0%> (ø)
.../agent/src/simcore_service_agent/models/volumes.py 100.0% <100.0%> (ø)
...src/simcore_service_agent/services/docker_utils.py 98.3% <100.0%> (ø)
...r/src/simcore_service_clusters_keeper/constants.py 100.0% <100.0%> (ø)
...c/simcore_service_clusters_keeper/core/settings.py 100.0% <100.0%> (ø)
...invitations/src/simcore_service_invitations/cli.py 92.1% <ø> (ø)
...s/src/simcore_service_invitations/core/settings.py 97.4% <ø> (ø)
...servicelib/rabbitmq/rpc_interfaces/agent/errors.py 0.0% <0.0%> (ø)

@GitHK GitHK marked this pull request as ready for review October 16, 2024 11:44
@GitHK GitHK requested a review from sanderegg October 16, 2024 11:44
@GitHK GitHK changed the title 🎨 bring agent to pydanticv2 🎨 pydnatic2 migration: fixed unit-tests for agent Oct 16, 2024
@GitHK GitHK changed the title 🎨 pydnatic2 migration: fixed unit-tests for agent 🎨 pydantic2 migration: fixed unit-tests for agent Oct 16, 2024
@sonarqubecloud
Copy link

@GitHK GitHK merged commit b9a27e8 into ITISFoundation:pydantic_v2_migration Oct 18, 2024
42 of 57 checks passed
@GitHK GitHK deleted the pr-osparc-pydanticv2-agent2 branch October 18, 2024 11:39
sanderegg pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:agent agent service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants