Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 16, 2024

What do these changes do?

  • ⬆️ updated dependencies
  • made unit tests green

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK added t:maintenance Some planned maintenance work a:dynamic-scheduler labels Oct 16, 2024
@GitHK GitHK added this to the MartinKippenberger milestone Oct 16, 2024
@GitHK GitHK self-assigned this Oct 16, 2024
@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration@b7384d4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...c/simcore_service_dynamic_scheduler/core/errors.py 0.0% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6547   +/-   ##
=======================================================
  Coverage                         ?   81.2%           
=======================================================
  Files                            ?     536           
  Lines                            ?   21862           
  Branches                         ?    1336           
=======================================================
  Hits                             ?   17757           
  Misses                           ?    3864           
  Partials                         ?     241           
Flag Coverage Δ
unittests 81.2% <88.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-library/src/common_library/pydantic_validators.py 87.5% <100.0%> (ø)
...ls_library/api_schemas_webserver/projects_nodes.py 96.8% <ø> (ø)
...library/src/servicelib/fastapi/exceptions_utils.py 95.0% <100.0%> (ø)
...simcore_service_dynamic_scheduler/core/settings.py 100.0% <100.0%> (ø)
...e_service_dynamic_scheduler/models/schemas/meta.py 100.0% <100.0%> (ø)
...c_scheduler/services/director_v2/_public_client.py 92.1% <100.0%> (ø)
...dynamic_scheduler/services/service_tracker/_api.py 88.5% <100.0%> (ø)
...c/simcore_service_dynamic_sidecar/core/settings.py 97.3% <100.0%> (ø)
...c/simcore_service_dynamic_scheduler/core/errors.py 0.0% <0.0%> (ø)

@GitHK GitHK changed the title 🎨 Pr osparc pydanticv2 dynamic scheduler2 🎨 pydnatic2 migration: fixed unit-tests for dynamic-scheduler Oct 16, 2024
@GitHK GitHK marked this pull request as ready for review October 16, 2024 12:55
@GitHK GitHK changed the title 🎨 pydnatic2 migration: fixed unit-tests for dynamic-scheduler 🎨 pydantic2 migration: fixed unit-tests for dynamic-scheduler Oct 16, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sonarqubecloud
Copy link

@GitHK GitHK merged commit 6906e94 into ITISFoundation:pydantic_v2_migration Oct 18, 2024
38 of 57 checks passed
@GitHK GitHK deleted the pr-osparc-pydanticv2-dynamic-scheduler2 branch October 18, 2024 09:26
sanderegg pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:dynamic-scheduler t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants