-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 pydantic2 migration: fixed unit-tests for dynamic-scheduler #6547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GitHK
merged 13 commits into
ITISFoundation:pydantic_v2_migration
from
GitHK:pr-osparc-pydanticv2-dynamic-scheduler2
Oct 18, 2024
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
556b259
update requirements
56ccda3
ported dynamic-scheduler
143f13c
using not deprecated forms
f9dbe53
mypy
e0a195b
Merge remote-tracking branch 'upstream/pydantic_v2_migration' into pr…
c28d1cc
removed adapter pattern
79dc0e1
revert adapter pattern
237eee5
revert adapter pattern
1a3999c
revert adapter pattern
79384bb
fixed exception handler
d5fcc1c
rename
1ccfddb
debug in ci
5cbe4f2
disable monitor to avoid interference in tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
20 changes: 20 additions & 0 deletions
20
packages/common-library/src/common_library/pydantic_validators.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import datetime | ||
|
|
||
| from pydantic import field_validator | ||
|
|
||
|
|
||
| def _try_convert_str_to_float_or_return( | ||
| v: datetime.timedelta | str | float, | ||
| ) -> datetime.timedelta | str | float: | ||
| if isinstance(v, str): | ||
| try: | ||
| return float(v) | ||
| except ValueError: | ||
| # returns format like "1:00:00" | ||
| return v | ||
| return v | ||
|
|
||
|
|
||
| def timedelta_try_convert_str_to_float(field: str): | ||
| """Transforms a float/int number into a valid datetime as it used to work in the past""" | ||
| return field_validator(field, mode="before")(_try_convert_str_to_float_or_return) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.