♻️ 📝 Minor refactor and doc of autoscaling service

[pcrespov]

What do these changes do?

Minor refactor and documentation update for autoscaling service

• ♻️ Refactored get_ec2_instance_capabilities to guarantee a sorted return value.
• 🎨 Added a warning log when EC2_INSTANCES_ALLOWED_TYPE is empty.
  • Note: While I believe we should prevent this scenario altogether, I opted to maintain the current logic and only introduce a warning to avoid altering the original intent.
• 📝♻️ Added minimal doc or refactor code to clarify code intentions.

Related issue/s

• Towards fixing Autoscaling: scaling down unused machines while asking for other types of machines does not work #6367

How to test

cd services/autoscaling
make install-dev
pytest -vv tests/unit/test_modules_auto_scaling_core.py

Dev-ops checklist

None

[codecov]

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.5%. Comparing base (cafbf96) to head (d5c816c).
Report is 651 commits behind head on master.

Files with missing lines	Patch %	Lines
...mq/rpc_interfaces/clusters_keeper/ec2_instances.py	0.0%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6551      +/-   ##
=========================================
+ Coverage    84.5%   87.5%    +2.9%     
=========================================
  Files          10    1256    +1246     
  Lines         214   54886   +54672     
  Branches       25    1243    +1218     
=========================================
+ Hits          181   48035   +47854     
- Misses         23    6641    +6618     
- Partials       10     210     +200     

Flag	Coverage Δ
integrationtests	64.7% <ø> (?)
unittests	85.1% <96.4%> (+0.6%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ackages/aws-library/src/aws_library/ec2/_client.py	100.0% <100.0%> (ø)
...vice_integration/pytest_plugin/folder_structure.py	0.0% <ø> (ø)
...g/src/simcore_service_autoscaling/core/settings.py	100.0% <100.0%> (ø)
...e_service_autoscaling/modules/auto_scaling_core.py	89.3% <100.0%> (ø)
...mcore_service_clusters_keeper/rpc/ec2_instances.py	100.0% <100.0%> (ø)
...mq/rpc_interfaces/clusters_keeper/ec2_instances.py	0.0% <0.0%> (ø)

... and 1245 files with indirect coverage changes

[matusdrobuliak66]

👍

[GitHK]

It's not just a documentation refactor it's change

[sanderegg]

Thanks for the first draft, but an empty EC2_INSTANCES_ALLOWED_TYPES means that no type is allowed. What your change does is to accept anything, which goes against how the system works.

[pcrespov]

Thanks for the first draft, but an empty EC2_INSTANCES_ALLOWED_TYPES means that no type is allowed. What your change does is to accept anything, which goes against how the system works.

@sanderegg As I mentioned above in the description, this behaviour was already like this. I found it strange but I just did not want to change the logic. Now i see that probably you were not aware of this issue so let me show you and we can change it

[sanderegg]

great thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud