From 89a327a0dfd79d2f6240d432b7633716f1224354 Mon Sep 17 00:00:00 2001 From: sanderegg <35365065+sanderegg@users.noreply.github.com> Date: Wed, 23 Oct 2024 21:39:52 +0200 Subject: [PATCH 1/5] reduced log level of faststream broker --- .../src/servicelib/deferred_tasks/_deferred_manager.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py b/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py index 2427b25340e7..b81fb496ddac 100644 --- a/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py +++ b/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py @@ -134,7 +134,12 @@ def __init__( ClassUniqueReference, type[BaseDeferredHandler] ] = {} - self.broker: RabbitBroker = RabbitBroker(rabbit_settings.dsn) + # NOTE: this logger is very noisy, or the way we use it makes it very noisy. + # in the end this creates 1000s of useless logs everytime a message passes, + # creating 1000s of INFO logs per minute. ANE I let you fix it. + self.broker: RabbitBroker = RabbitBroker( + rabbit_settings.dsn, logger=_logger, log_level=logging.DEBUG + ) self.router: RabbitRouter = RabbitRouter() # NOTE: do not move this to a function, must remain in constructor From 01b68a34a8466d088b2a058f4c61137943b75ddd Mon Sep 17 00:00:00 2001 From: sanderegg <35365065+sanderegg@users.noreply.github.com> Date: Wed, 23 Oct 2024 21:40:41 +0200 Subject: [PATCH 2/5] reduced log level of faststream broker --- .../src/servicelib/deferred_tasks/_deferred_manager.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py b/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py index b81fb496ddac..8227334687a9 100644 --- a/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py +++ b/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py @@ -136,7 +136,8 @@ def __init__( # NOTE: this logger is very noisy, or the way we use it makes it very noisy. # in the end this creates 1000s of useless logs everytime a message passes, - # creating 1000s of INFO logs per minute. ANE I let you fix it. + # creating 1000s of INFO logs per minute, as INFO is the default log level + # for messages. ANE I let you fix it. self.broker: RabbitBroker = RabbitBroker( rabbit_settings.dsn, logger=_logger, log_level=logging.DEBUG ) From 868aae140bac8485dd229417af5659cdd73a0adc Mon Sep 17 00:00:00 2001 From: sanderegg <35365065+sanderegg@users.noreply.github.com> Date: Wed, 23 Oct 2024 22:04:21 +0200 Subject: [PATCH 3/5] done --- .../core/application.py | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py b/services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py index e6ba2bbb53f7..3815c1a70925 100644 --- a/services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py +++ b/services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py @@ -1,3 +1,5 @@ +import logging + from fastapi import FastAPI from servicelib.fastapi.openapi import override_fastapi_openapi_method from servicelib.fastapi.profiler_middleware import ProfilerMiddleware @@ -26,10 +28,28 @@ from ..services.status_monitor import setup_status_monitor from .settings import ApplicationSettings +LOG_LEVEL_STEP = logging.CRITICAL - logging.ERROR +NOISY_LOGGERS = ( + "faststream", + "faststream.access", + "simcore_service_dynamic_scheduler.services.deferred_manager_common", +) + +_logger = logging.getLogger(__name__) + def create_app(settings: ApplicationSettings | None = None) -> FastAPI: app_settings = settings or ApplicationSettings.create_from_envs() + # keep mostly quiet noisy loggers + quiet_level: int = max( + min(logging.root.level + LOG_LEVEL_STEP, logging.CRITICAL), logging.WARNING + ) + for name in NOISY_LOGGERS: + logging.getLogger(name).setLevel(quiet_level) + + _logger.debug("App settings:\n%s", app_settings.json(indent=2)) + app = FastAPI( title=f"{PROJECT_NAME} web API", description=SUMMARY, From 958d0b7ddd42e277c495a6ac99db018a6f800c51 Mon Sep 17 00:00:00 2001 From: sanderegg <35365065+sanderegg@users.noreply.github.com> Date: Wed, 23 Oct 2024 22:09:39 +0200 Subject: [PATCH 4/5] done --- .../src/servicelib/deferred_tasks/_deferred_manager.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py b/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py index 8227334687a9..b49990a78341 100644 --- a/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py +++ b/packages/service-library/src/servicelib/deferred_tasks/_deferred_manager.py @@ -134,12 +134,8 @@ def __init__( ClassUniqueReference, type[BaseDeferredHandler] ] = {} - # NOTE: this logger is very noisy, or the way we use it makes it very noisy. - # in the end this creates 1000s of useless logs everytime a message passes, - # creating 1000s of INFO logs per minute, as INFO is the default log level - # for messages. ANE I let you fix it. self.broker: RabbitBroker = RabbitBroker( - rabbit_settings.dsn, logger=_logger, log_level=logging.DEBUG + rabbit_settings.dsn, log_level=logging.DEBUG ) self.router: RabbitRouter = RabbitRouter() From 09506cf9eb649a4925001afe2bd27a270573bc97 Mon Sep 17 00:00:00 2001 From: sanderegg <35365065+sanderegg@users.noreply.github.com> Date: Wed, 23 Oct 2024 22:10:23 +0200 Subject: [PATCH 5/5] revert --- .../core/application.py | 20 ------------------- 1 file changed, 20 deletions(-) diff --git a/services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py b/services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py index 3815c1a70925..e6ba2bbb53f7 100644 --- a/services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py +++ b/services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py @@ -1,5 +1,3 @@ -import logging - from fastapi import FastAPI from servicelib.fastapi.openapi import override_fastapi_openapi_method from servicelib.fastapi.profiler_middleware import ProfilerMiddleware @@ -28,28 +26,10 @@ from ..services.status_monitor import setup_status_monitor from .settings import ApplicationSettings -LOG_LEVEL_STEP = logging.CRITICAL - logging.ERROR -NOISY_LOGGERS = ( - "faststream", - "faststream.access", - "simcore_service_dynamic_scheduler.services.deferred_manager_common", -) - -_logger = logging.getLogger(__name__) - def create_app(settings: ApplicationSettings | None = None) -> FastAPI: app_settings = settings or ApplicationSettings.create_from_envs() - # keep mostly quiet noisy loggers - quiet_level: int = max( - min(logging.root.level + LOG_LEVEL_STEP, logging.CRITICAL), logging.WARNING - ) - for name in NOISY_LOGGERS: - logging.getLogger(name).setLevel(quiet_level) - - _logger.debug("App settings:\n%s", app_settings.json(indent=2)) - app = FastAPI( title=f"{PROJECT_NAME} web API", description=SUMMARY,