Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 4, 2024

What do these changes do?

Brings the director-v0 to the new age.

  • FastAPI-based, using pydantic v1 latest (will need to be migrated),
  • python 3.11, dockerfile, etc etc
  • uses aiocache instead of home-made cache (should actually allow to cache in redis),
  • DIRECTOR_PORT is now on 8000
  • added DIRECTOR_LOG_FORMAT_LOCAL_DEV_ENABLED or LOG_FORMAT_LOCAL_DEV_ENABLED

image

Related issue/s

How to test

  • Manual testing to test deploy🚨
    • @sanderegg can you describe some basic tests here please?
  • Driving tests
cd services/director
make install-dev
make test-dev-unit

Dev-ops ⚠️

@YuryHrytsuk @mrnicegyu11 please check&confirm this section. thx

  • Updated environment variables in the osparc-config repository in MR 1071 for deployments based on the master branch.
  • Note that this new configuration is not backward-compatible with the previous setup of the director. Deployments to staging and production will require synchronizing the merge of multiple MRs (see below) to the osparc-config repository with the timing of this code reaching the respective release environments.

@pcrespov pcrespov added the a:director issue related with the director service label Nov 4, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Nov 4, 2024
@pcrespov pcrespov enabled auto-merge (squash) November 14, 2024 22:06
@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit 050b3e6 into ITISFoundation:master Nov 18, 2024
85 of 89 checks passed
@pcrespov pcrespov deleted the is1988/upgrading-director-to-fastapi branch November 19, 2024 08:43
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director issue related with the director service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants