Skip to content

Conversation

@sanderegg
Copy link
Member

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

giancarloromeo and others added 30 commits September 18, 2024 11:45
⬆️Update from upstream (must be merged-commited)
sanderegg and others added 25 commits October 29, 2024 09:17
⬆️ Update from upstream/master (do not squash!)
…ter-10

⬆️Update from upstream/master
Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Sylvain <[email protected]>
@sanderegg sanderegg self-assigned this Nov 15, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 87.13204% with 153 lines in your changes missing coverage. Please review.

Project coverage is 68.15%. Comparing base (cb74ff7) to head (d2f89de).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cb74ff7) and HEAD (d2f89de). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (cb74ff7) HEAD (d2f89de)
unittests 31 23
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6726       +/-   ##
===========================================
- Coverage   87.73%   68.15%   -19.58%     
===========================================
  Files        1570     1453      -117     
  Lines       63323    58284     -5039     
  Branches     2119     2261      +142     
===========================================
- Hits        55554    39724    -15830     
- Misses       7443    18214    +10771     
- Partials      326      346       +20     
Flag Coverage Δ *Carryforward flag
integrationtests 53.33% <ø> (-11.58%) ⬇️ Carriedforward from 44bc9f7
unittests 83.26% <87.13%> (-2.43%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.32% <80.43%> (-0.07%) ⬇️
pkg_dask_task_models_library 96.61% <100.00%> (-0.27%) ⬇️
pkg_models_library 91.31% <91.41%> (-0.70%) ⬇️
pkg_notifications_library 84.57% <0.00%> (+0.78%) ⬆️
pkg_postgres_database 87.30% <100.00%> (-0.03%) ⬇️
pkg_service_integration 70.00% <98.24%> (-1.44%) ⬇️
pkg_service_library 76.38% <ø> (-0.18%) ⬇️
pkg_settings_library 90.90% <ø> (-0.52%) ⬇️
pkg_simcore_sdk 78.26% <ø> (-7.01%) ⬇️
agent 97.01% <ø> (+0.02%) ⬆️
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog 90.57% <ø> (+1.14%) ⬆️
clusters_keeper 98.73% <ø> (+<0.01%) ⬆️
dask_sidecar 90.87% <ø> (-0.46%) ⬇️
datcore_adapter 93.17% <ø> (-0.88%) ⬇️
director 58.43% <ø> (+0.04%) ⬆️
director_v2 76.29% <ø> (-14.50%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 59.79% <ø> (-30.00%) ⬇️
efs_guardian 90.12% <ø> (+0.10%) ⬆️
invitations 93.49% <ø> (-0.03%) ⬇️
osparc_gateway_server 85.74% <ø> (+0.33%) ⬆️
payments 92.77% <ø> (-0.11%) ⬇️
resource_usage_tracker 90.61% <ø> (-0.16%) ⬇️
storage 89.66% <ø> (-0.11%) ⬇️
webclient ∅ <ø> (∅)
webserver 40.60% <ø> (-48.12%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb74ff7...d2f89de. Read the comment docs.

@sanderegg sanderegg closed this Nov 15, 2024
@sanderegg sanderegg deleted the fix-unit-tests branch November 15, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants