🎨 [Frontend] Enh: Support multiple announcements #6729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
odeimaiz
requested review from
GitHK,
matusdrobuliak66,
pcrespov and
sanderegg
matusdrobuliak66
approved these changes
Nov 15, 2024
GitHK
approved these changes
Nov 18, 2024
jsaq007
approved these changes
Nov 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
At the moment, the frontend only works as expected when only one announcement is provided (depending on the order can handle two). This PR makes the frontend handle multiple announcements.
Demo with 6 announcements: 2 login + 2 ribbon + 2 user-menu:
Related issue/s
How to test
Dev-ops checklist