Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 19, 2024

What do these changes do?

Fix pylint on Director-v2.

Related issue/s

How to test

cd services/director-v2
make pylint

Dev-ops checklist

@giancarloromeo giancarloromeo added t:maintenance Some planned maintenance work a:director-v2 issue related with the director-v2 service labels Nov 19, 2024
@giancarloromeo giancarloromeo self-assigned this Nov 19, 2024
@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo marked this pull request as ready for review November 19, 2024 10:30
@giancarloromeo giancarloromeo enabled auto-merge (squash) November 19, 2024 10:36
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can discuss that one.

@giancarloromeo giancarloromeo marked this pull request as draft November 19, 2024 10:56
auto-merge was automatically disabled November 19, 2024 10:56

Pull request was converted to draft

@giancarloromeo
Copy link
Contributor Author

Aborted

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (c10d7d0) to head (77e2549).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6761      +/-   ##
===============================================================================
- Coverage                                        84.94%   84.46%   -0.48%     
===============================================================================
  Files                                             1252     1382     +130     
  Lines                                            48907    56132    +7225     
  Branches                                          1296     1296              
===============================================================================
+ Hits                                             41544    47414    +5870     
- Misses                                            7185     8526    +1341     
- Partials                                           178      192      +14     
Flag Coverage Δ *Carryforward flag
integrationtests 53.42% <100.00%> (-4.63%) ⬇️
unittests 84.43% <ø> (ø) Carriedforward from c10d7d0

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 79.60% <ø> (ø)
pkg_aws_library 93.32% <ø> (ø)
pkg_dask_task_models_library 96.61% <ø> (ø)
pkg_models_library 91.10% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.31% <ø> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.37% <ø> (+19.67%) ⬆️
agent 97.01% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.07% <ø> (ø)
director_v2 76.24% <100.00%> (∅)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.79% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.49% <ø> (+45.33%) ⬆️
payments 92.77% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 79.34% <ø> (-0.81%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10d7d0...77e2549. Read the comment docs.

---- 🚨 Try these New Features:

@giancarloromeo giancarloromeo deleted the is6756/fix-director-v2-pylint branch November 21, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants