Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 19, 2024

What do these changes do?

As requested by @matusdrobuliak66, this PR adds some osparc-test-ids to Folders and Workspaces related UI elements

  • New Folder button newFolderButton
    • New Folder window: Title field folderEditorTitle
    • New Folder window: Create button folderEditorCreate
  • Folder button folderItem_${folderId}
    • Menu (three dots) folderItemMenuButton
      • Move to moveFolderMenuItem
      • Delete deleteFolderMenuItem
      • The confirm Delete button confirmDeleteFolderButton
  • New workspace button newFolderButton
    • New workspace window: Title field workspaceEditorTitle
    • New workspace window: Save button workspaceEditorSave
  • Workspace button workspaceItem_${workspaceId}
    • Menu (three dots) workspaceItemMenuButton
      • Delete deleteWorkspaceMenuItem
      • The confirm Delete button confirmDeleteWorkspaceButton
  • Left tree items workspacesAndFoldersTreeItem_${workspaceId}_${folderId}

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 19, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 19, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Nov 19, 2024
@odeimaiz odeimaiz marked this pull request as ready for review November 19, 2024 14:29
@matusdrobuliak66
Copy link
Collaborator

Thanks! 💯

@sonarqubecloud
Copy link

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At very quick look. Seems ok to me

@odeimaiz odeimaiz merged commit c41b681 into ITISFoundation:master Nov 19, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants