Skip to content

⬆️♻️ WIP: Fixes openapi generators for web-api, i.e. api/specs/web-server #6771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

⬆️♻️ WIP: Fixes openapi generators for web-api, i.e. api/specs/web-server #6771

wants to merge 12 commits into from

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 19, 2024 •
edited
Loading

What do these changes do?

  • Fixes openapi generators for web-api, i.e. api/specs/web-server
    • "_catalog", < ---- FIXME: Invalid args for response field! Hint: check that <class 'models_library.api_schemas_webserver.catalog.ServiceResourcesGet'> is a valid Pydantic field type
    • "_cluster" <--- FIXME: :TypeError: unhashable type: 'ClusterAccessRights'
    • "_publications" <--- FIXME: RuntimeWarning: fields may not start with an underscore, ignoring "_file"
    • How to modify schema in class Json for pydantic v2?
      image

Related issue/s

@pcrespov pcrespov added this to the Event Horizon milestone Nov 19, 2024
@pcrespov pcrespov self-assigned this Nov 19, 2024
@pcrespov pcrespov marked this pull request as draft November 19, 2024 19:22
@codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (c38b064) to head (821604b).
Report is 13 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files 
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6771      +/-   ##
===============================================================================
- Coverage                                        88.40%   84.83%   -3.58%     
===============================================================================
  Files                                             1545     1254     -291     
  Lines                                            61635    53145    -8490     
  Branches                                          2100      885    -1215     
===============================================================================
- Hits                                             54490    45084    -9406     
- Misses                                            6817     7926    +1109     
+ Partials                                           328      135     -193
Flag Coverage Δ
integrationtests 64.78% <ø> (-0.01%) ⬇️
unittests 83.07% <100.00%> (-4.01%) ⬇️
Components Coverage Δ
api 79.60% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.23% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 75.97% <ø> (-0.03%) ⬇️
director_v2 91.15% <ø> (+0.09%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (+0.03%) ⬆️
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker 90.64% <ø> (-0.15%) ⬇️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 75.32% <ø> (-13.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38b064...821604b. Read the comment docs.

---- 🚨 Try these New Features:

sanderegg
sanderegg approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not completely sure I understand what you are trying to do here. especially the Jsonstr and the comments in openapi.py

@pcrespov
Copy link
Member Author

pcrespov commented Nov 20, 2024

not completely sure I understand what you are trying to do here. especially the Jsonstr and the comments in openapi.py
@sanderegg this is still draft

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

matusdrobuliak66
matusdrobuliak66 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you need to explain me which of these changes fixed the open api specs for folder ID from int -> int | none

@pcrespov pcrespov mentioned this pull request Nov 21, 2024
Merged
@pcrespov
Copy link
Member Author

pcrespov commented Nov 21, 2024

After merging #6578 into master we follow up this in #6787

@pcrespov pcrespov closed this Nov 21, 2024
@pcrespov pcrespov deleted the fix/api-specs branch November 21, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@pcrespov pcrespov

Labels

None yet

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

3 participants

@pcrespov @sanderegg @matusdrobuliak66