Skip to content

💣 Remove osparc-gateway-server and clusters endpoints #6881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Dec 3, 2024
Merged

💣 Remove osparc-gateway-server and clusters endpoints #6881

merged 45 commits into from
Dec 3, 2024

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 2, 2024 •
edited
Loading

What do these changes do?

  • 💣 deleted osparc-gateway-server service
  • 💣 removed dask-gateway library everywhere
  • 💣 removed dask-gateway-server library everywhere
  • 💣 removed Clusters entrypoints in webserver
  • 💣 removed Clusters entrypoints in director-v2

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:director-v2 issue related with the director-v2 service labels Dec 2, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Dec 2, 2024
@sanderegg sanderegg self-assigned this Dec 2, 2024
@codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.31%. Comparing base (f9f2148) to head (2ade1cb).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6881      +/-   ##
==========================================
- Coverage   88.36%   88.31%   -0.05%     
==========================================
  Files        1560     1546      -14     
  Lines       62009    60975    -1034     
  Branches     2110     2095      -15     
==========================================
- Hits        54794    53852     -942     
+ Misses       6882     6791      -91     
+ Partials      333      332       -1
Flag Coverage Δ
integrationtests 65.04% <84.00%> (+0.18%) ⬆️
unittests 86.49% <96.22%> (+0.20%) ⬆️
Components Coverage Δ
api 78.42% <ø> (ø)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.21% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.76% <ø> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 76.07% <ø> (ø)
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.81% <100.00%> (+0.08%) ⬆️
autoscaling 95.21% <100.00%> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.72% <100.00%> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.37% <95.00%> (-0.08%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.77% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.24% <100.00%> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f2148...2ade1cb. Read the comment docs.

@odeimaiz odeimaiz mentioned this pull request Dec 2, 2024
Closed
1 task
@sanderegg sanderegg marked this pull request as ready for review December 2, 2024 16:16
@sanderegg sanderegg requested a review from odeimaiz December 2, 2024 16:20
GitHK
GitHK approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP

odeimaiz
odeimaiz reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg sanderegg requested a review from mguidon December 2, 2024 16:32
@sanderegg sanderegg force-pushed the disable-osparc-gateway-server branch 2 times, most recently from 80a401d to c6ae907 Compare December 2, 2024 21:49
pcrespov
pcrespov approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boom! :-)

YuryHrytsuk
YuryHrytsuk reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also remove this ENV from osparc-config?

@sanderegg sanderegg force-pushed the disable-osparc-gateway-server branch 2 times, most recently from 447e5a5 to a529200 Compare December 3, 2024 13:06
@sanderegg sanderegg force-pushed the disable-osparc-gateway-server branch from 7f5d94f to 83cd7ba Compare December 3, 2024 14:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

matusdrobuliak66
matusdrobuliak66 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg
Copy link
Member Author

sanderegg commented Dec 3, 2024

Shall we also remove this ENV from osparc-config?

@YuryHrytsuk yes but deploy by deploy. same as when changing an ENV.

@sanderegg sanderegg merged commit fd62ccf into ITISFoundation:master Dec 3, 2024
95 of 99 checks passed
@sanderegg sanderegg deleted the disable-osparc-gateway-server branch December 3, 2024 17:25
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 10, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odeimaiz odeimaiz odeimaiz left review comments

@YuryHrytsuk YuryHrytsuk YuryHrytsuk left review comments

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo giancarloromeo is a code owner

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@sanderegg sanderegg

Labels

a:director-v2 issue related with the director-v2 service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

6 participants

@sanderegg @GitHK @pcrespov @odeimaiz @YuryHrytsuk @matusdrobuliak66