Skip to content

🐛 [Frontend] Fix: Move folder to a different workspace and subfolder #6903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 5, 2024
Merged

🐛 [Frontend] Fix: Move folder to a different workspace and subfolder #6903

merged 11 commits into from
Dec 5, 2024

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 4, 2024 •
edited
Loading

What do these changes do?

  • Fix: The two calls (update workspace + update parentFolder) were done in parallel and should go one after the other.
  • Fix: Glitches in the tree when moving
  • Fix: Glitch in the move button in the Move To dialog

MoveFolders

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Dec 4, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Dec 4, 2024
@odeimaiz odeimaiz marked this pull request as ready for review December 4, 2024 15:50
@odeimaiz odeimaiz added this to the Event Horizon milestone Dec 4, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) December 4, 2024 15:52
sanderegg
sanderegg reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

pcrespov
pcrespov reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

GitHK
GitHK reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit cba896a into ITISFoundation:master Dec 5, 2024
51 checks passed
@odeimaiz odeimaiz deleted the fix/move-folder branch December 5, 2024 09:42
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 10, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

+1 more reviewer

@jsaq007 jsaq007 jsaq007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

6 participants

@odeimaiz @jsaq007 @GitHK @pcrespov @sanderegg @matusdrobuliak66