-
Notifications
You must be signed in to change notification settings - Fork 32
🐛♻️ web-api: fixes adding group member by user-name and some cleanup #6940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6c49ba9 to
7c13bdf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6940 +/- ##
==========================================
- Coverage 88.07% 87.97% -0.10%
==========================================
Files 1589 1600 +11
Lines 62233 62483 +250
Branches 2012 2045 +33
==========================================
+ Hits 54810 54969 +159
- Misses 7087 7167 +80
- Partials 336 347 +11
Continue to review full report in Codecov by Sentry.
|
364096b to
b0e3e8c
Compare
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good!
|



What do these changes do?
Following manual testing on the master deployment, we identified a use-case that was still not fully functional. This PR addresses the issue with a fix (including additional test coverage) and incorporates some simple (but noisy) cleanup refactoring in the
groupsdomain.add_group_userwithuserName:test_create_organization_and_add_usersfor improved validation.GroupIDtomodels_library.groupsfor better modularization.GroupTypefor both ORM and domain models by relocating it tocommon_library.groups_enum.Dockerfile. Did not include new dependency withcommon_library)Related issue/s
How to test