Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 11, 2024

What do these changes do?

  • ✨Autoscaling: scale down while in use 🚨 #6898 brought an issue that this PR hopefully fixes
  • the Docker Node tagging operation was not properly returning the updated Node object, therefore the node would be activated and instantly de-activated, which prevents any service from starting

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:autoscaling autoscaling service in simcore's stack label Dec 11, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Dec 11, 2024
@sanderegg sanderegg self-assigned this Dec 11, 2024
@sanderegg sanderegg force-pushed the autoscaling/bugfix/scale-down-while-in-use-2 branch from 3a63218 to ec62622 Compare December 11, 2024 21:44
@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.98%. Comparing base (08981e0) to head (756d29c).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (08981e0) and HEAD (756d29c). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (08981e0) HEAD (756d29c)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6953       +/-   ##
===========================================
- Coverage   88.08%   66.98%   -21.10%     
===========================================
  Files        1589      669      -920     
  Lines       62242    32759    -29483     
  Branches     2012      262     -1750     
===========================================
- Hits        54823    21943    -32880     
- Misses       7083    10756     +3673     
+ Partials      336       60      -276     
Flag Coverage Δ
integrationtests 64.99% <ø> (-3.09%) ⬇️
unittests 95.42% <85.71%> (+9.13%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling 95.42% <85.71%> (+<0.01%) ⬆️
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.86% <ø> (-12.48%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.57% <ø> (-28.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08981e0...756d29c. Read the comment docs.

@sanderegg sanderegg requested a review from pcrespov December 11, 2024 22:01
@sanderegg sanderegg force-pushed the autoscaling/bugfix/scale-down-while-in-use-2 branch from ec62622 to 756d29c Compare December 11, 2024 22:34
@sonarqubecloud
Copy link

@sanderegg sanderegg merged commit a612a27 into ITISFoundation:master Dec 11, 2024
89 of 90 checks passed
@sanderegg sanderegg deleted the autoscaling/bugfix/scale-down-while-in-use-2 branch December 11, 2024 22:49
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:autoscaling autoscaling service in simcore's stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants