♻️ Redirecting labels request via catalog in director-v2

[GitHK]

What do these changes do?

Since the ownership of a service's information is the catalog, a service's labels will now be provided by the catalog and should not be recovered via the director service.

Related issue/s

• required by ✨ Adding director-v0 client to dynamic-scheduler #7001

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.30%. Comparing base (0963820) to head (6fc086b).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (0963820) and HEAD (6fc086b). Click for more details.

HEAD has 32 uploads less than BASE

Flag	BASE (0963820)	HEAD (6fc086b)
integrationtests	7	6
unittests	34	3

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #7016       +/-   ##
===========================================
- Coverage   86.94%   71.30%   -15.65%     
===========================================
  Files        1649      727      -922     
  Lines       64791    34937    -29854     
  Branches     2041      262     -1779     
===========================================
- Hits        56335    24912    -31423     
- Misses       8118     9965     +1847     
+ Partials      338       60      -278     

Flag	Coverage Δ
integrationtests	64.87% <79.16%> (+0.27%)	⬆️
unittests	84.65% <87.50%> (-2.04%)	⬇️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.37% <ø> (-8.02%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	90.66% <100.00%> (+0.08%)	⬆️
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	76.49% <ø> (+0.08%)	⬆️
director_v2	91.39% <91.66%> (-0.02%)	⬇️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	89.74% <ø> (ø)
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
osparc_gateway_server	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	59.24% <ø> (-24.81%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0963820...6fc086b. Read the comment docs.

[sanderegg]

very nice, just a few questions regarding the availability of these labels:

• does it make sense to return all the labels? they are used in the resources api endpoint
• would it make more sense to return just what is necessary so that we do not start to use that endpoint in parallel to the resources one?

[pcrespov]

thx
dont forget to increase the minor version of the catalog as well

make version-minor

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sanderegg]

still a bit worried about making all the static labels available like so. but let's see what comes afterwards.