🐛Redis locks disappearing and fixup weird usage #7020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7020 +/- ##
==========================================
- Coverage 86.94% 86.31% -0.63%
==========================================
Files 1651 1615 -36
Lines 64811 63147 -1664
Branches 2041 2043 +2
==========================================
- Hits 56351 54507 -1844
- Misses 8122 8305 +183
+ Partials 338 335 -3
Continue to review full report in Codecov by Sentry.
|
sanderegg
force-pushed
the
bugfixes/redis-lock-failing2
branch
3 times, most recently
from
1d6a299 to
cd8df19
Compare
sanderegg
force-pushed
the
bugfixes/redis-lock-failing2
branch
2 times, most recently
from
7563c97 to
9759786
Compare
sanderegg
requested review from
GitHK,
matusdrobuliak66 and
pcrespov
as code owners
matusdrobuliak66
approved these changes
Jan 14, 2025
Collaborator
matusdrobuliak66
left a comment
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Thanks for the effort 🥇
GitHK
approved these changes
Jan 14, 2025
Contributor
GitHK
left a comment
GitHK
left a comment
There was a problem hiding this comment.
Very nice! Thanks for looking into this annoying issue.
packages/service-library/src/servicelib/background_task_utils.py
Outdated
Show resolved
Hide resolved
sanderegg
force-pushed
the
bugfixes/redis-lock-failing2
branch
from
ececacd to
746fffb
Compare
pcrespov
approved these changes
Jan 14, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
Fantastic redesign! I left some suggestions and a warning regarding func.__name__.
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In short
lock_contextis goneexclusivedecorator shall be used insteadexclusive_periodicdecorator is now the solution when one wants a background task that runs exclusively on one replica of a service, with automatic recovery in case the replica is stopped/crashed.Details
lock_contextcontext manager is gone as it has an inherent flaw if the lock disappears from the Redis database for whatever reason it will not raiseexclusivedecorator was re-written without usinglock_contextand is now the de-factor way of protecting functions with a distributed lock. This is the way nowasyncio.Taskasyncio.Tasks! Thus proving difficult to cancel them.background_task.pymodule that now also provides a decoratorperiodicwhich wraps tenacity ownretrydecorator with some standard parametersasync_delayeddecorator towith_delayintoasync_utils.pylock_contextcontext manager withexclusivedecorator repo-wideexclusive_periodicdecoratorRelated issue/s
How to test
Dev-ops checklist