🎨 [Frontend] Lazy load stranger-users' metadata #7021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
odeimaiz
changed the title
Collaborator
|
Thanks! Do you need to click on the tooltip to trigger it, or hover over it? |
matusdrobuliak66
approved these changes
Jan 10, 2025
Member
Author
Just hovering the share icon will trigger the request and then populate the text 👍 |
giancarloromeo
approved these changes
Jan 10, 2025
|
ignapas
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
After introducing the "stranger-users" feature, when displaying a card (study, template, service), in order to populate the sharing icon's tooltip with the userName/groupName of the sharees, the frontend requests the information of the
groups/strangers_group_id/users's metadata, which can be an expensive call if it's made in parallel by all shared resources represented in the cards.This PR changes that logic and makes this information to be populated/requested only when it's required.
Lazy load on tooltip:
Lazy load on members list:
Related issue/s
How to test
Dev-ops checklist