Skip to content

🎨 fix locust_settings #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

🎨 fix locust_settings #7038

merged 2 commits into from
Jan 14, 2025

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jan 14, 2025 •
edited
Loading

What do these changes do?

  • Remove uv header to fix webresponsitivity tests

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Jan 14, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review January 14, 2025 09:45
@mrnicegyu11
Copy link
Member

mrnicegyu11 commented Jan 14, 2025

lol, you know you work in a complex system when removing fully commented code (i.e. not ever executed, hopefully) fixes a bug :D

@bisgaard-itis
Copy link
Contributor Author

bisgaard-itis commented Jan 14, 2025

lol, you know you work in a complex system when removing fully commented code (i.e. not ever executed, hopefully) fixes a bug :D

Apparently uv uses this and because of it the webresponsitivity tests seem to fail

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) January 14, 2025 09:59
@codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (f0212cb) to head (c7db61b).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7038      +/-   ##
==========================================
- Coverage   86.94%   86.44%   -0.51%     
==========================================
  Files        1651     1651              
  Lines       64811    64811              
  Branches     2041     2041              
==========================================
- Hits        56353    56028     -325     
- Misses       8120     8445     +325     
  Partials      338      338
Flag Coverage Δ *Carryforward flag
integrationtests 63.49% <ø> (-1.02%) ⬇️
unittests 85.87% <ø> (ø) Carriedforward from 6924ecb

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.58% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.27% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 73.87% <ø> (ø)
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.57% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.36% <ø> (ø)
dynamic_scheduler 97.19% <ø> (ø)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.50% <ø> (ø)
storage 89.59% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 82.46% <ø> (-1.60%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0212cb...c7db61b. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

matusdrobuliak66
matusdrobuliak66 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bisgaard-itis bisgaard-itis merged commit 082ec0b into ITISFoundation:master Jan 14, 2025
91 of 93 checks passed
@bisgaard-itis bisgaard-itis deleted the remove-uv-header-in-settings-py branch January 14, 2025 10:35
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

Assignees

@bisgaard-itis bisgaard-itis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bisgaard-itis @mrnicegyu11 @sanderegg @matusdrobuliak66