✅ 🔨 Maintenance: resolves tests hanging in CI #7077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7077 +/- ##
==========================================
+ Coverage 87.15% 87.69% +0.53%
==========================================
Files 1634 1626 -8
Lines 64353 63619 -734
Branches 2053 2054 +1
==========================================
- Hits 56089 55788 -301
+ Misses 7927 7495 -432
+ Partials 337 336 -1
Continue to review full report in Codecov by Sentry.
|
pcrespov
force-pushed
the
mai/hanging-ci
branch
2 times, most recently
from
89a4fb5 to
eb41779
Compare
pcrespov
force-pushed
the
mai/hanging-ci
branch
from
eb41779 to
4f3801d
Compare
pcrespov
changed the title
pcrespov
added
the
a:database
pcrespov
requested review from
GitHK,
matusdrobuliak66 and
sanderegg
as code owners
sanderegg
reviewed
Jan 28, 2025
packages/service-library/tests/deferred_tasks/test_deferred_tasks.py
Outdated
Show resolved
Hide resolved
sanderegg
approved these changes
Jan 28, 2025
giancarloromeo
approved these changes
Jan 28, 2025
bisgaard-itis
approved these changes
Jan 28, 2025
GitHK
approved these changes
Jan 28, 2025
matusdrobuliak66
approved these changes
Jan 28, 2025
|
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The primary goal of this PR was to resolve the issue of hanging CI tests. Initially, we suspected it was related to #7008. Although we implemented a fix in #7018, similar tests continued to hang.
Additionally, we identified that the Redis health check was repeatedly retrying indefinitely in
[int] webserver 02and[unit] service-library. To address this, I introduced a maximum cancellation time for the associated health check task, which appears to have resolved the issue.Overall, the primary cause of the hanging tests, as I noted in #7008, seems to be uncontrolled tasks persistently attempting to access services (e.g., database, Redis) that have already been shut down. This issue needs a follow up!!!
Some mode details of the changes
pytest-simcoreand testsforce_drop_all_tablesfor testing in a single call used everywhere ( this was the fix used in ♻️ web-server: preparation of trash plugin ⚠️ #7018)postgres-databaseservicelibRedisClientSDK.shutdownhas now a max time to cancel health-check taskconfigurations
.ruff.tomlremoving warnings due to new configurationRelated issue/s
How to test
Dev-ops
None