From 9574ed81d22661f23d9886caabc3a45118ce901d Mon Sep 17 00:00:00 2001 From: Andrei Neagu Date: Mon, 27 Jan 2025 10:45:53 +0100 Subject: [PATCH 1/3] log error cleanup --- .../src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py b/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py index 3c7a8bd9d60e..ca61a1d28256 100644 --- a/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py +++ b/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py @@ -13,7 +13,7 @@ def _parse_size(log_string): match = re.search(r"^\w+ (?P[^\/]+)", log_string) if match: - return match.group("size") + return match.group("size").replace("Bytes", "") return None From 12e5a5f570a7a77e6cbfc55924cda8035116eb31 Mon Sep 17 00:00:00 2001 From: Andrei Neagu Date: Mon, 27 Jan 2025 11:37:11 +0100 Subject: [PATCH 2/3] added small docstring --- .../src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py b/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py index ca61a1d28256..68e8fe97c149 100644 --- a/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py +++ b/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py @@ -13,6 +13,8 @@ def _parse_size(log_string): match = re.search(r"^\w+ (?P[^\/]+)", log_string) if match: + # NOTE: ByteSize does not know what `Bytes` are. + # It only knows about `b` and omitting the word bytes if they are just bytes. return match.group("size").replace("Bytes", "") return None From 8136e6cea1636a70f17a317ad4aeab33e5b863fd Mon Sep 17 00:00:00 2001 From: Andrei Neagu Date: Mon, 27 Jan 2025 13:17:51 +0100 Subject: [PATCH 3/3] added second exception --- .../src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py b/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py index 68e8fe97c149..d38c1c59d2b7 100644 --- a/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py +++ b/packages/simcore-sdk/src/simcore_sdk/node_ports_common/aws_s3_cli_utils.py @@ -13,9 +13,9 @@ def _parse_size(log_string): match = re.search(r"^\w+ (?P[^\/]+)", log_string) if match: - # NOTE: ByteSize does not know what `Bytes` are. + # NOTE: ByteSize does not know what `Bytes` or `Byte` are. # It only knows about `b` and omitting the word bytes if they are just bytes. - return match.group("size").replace("Bytes", "") + return match.group("size").replace("Bytes", "").replace("Byte", "") return None