Skip to content

✨ Updates licensed_items table πŸ—ƒοΈ #7144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 30, 2025
Merged

✨ Updates licensed_items table πŸ—ƒοΈ #7144

merged 10 commits into from
Jan 30, 2025

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 30, 2025 •
edited
Loading

What do these changes do?

πŸ—ƒοΈ Alters licensed_item table

  • renames name to licensed_resource_name
  • adds trashed timestamp mark
  • sets product_name, pricing_plan_id as nullable ( when both set, the item is "active")

🎨 Improves repository

  • adds filters for active and trash

🎨 Improves model conversion

  • conversion from domain to rest schema models

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv -ff tests/unit/**/test_license.py

## Dev-ops

@pcrespov pcrespov added this to the Singularity milestone Jan 30, 2025
@pcrespov pcrespov self-assigned this Jan 30, 2025
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:database associated to postgres service and postgres-database package a:models-library labels Jan 30, 2025
@pcrespov pcrespov marked this pull request as ready for review January 30, 2025 10:58
sanderegg
sanderegg approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.82%. Comparing base (b50e7e8) to head (1771b1c).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7144      +/-   ##
==========================================
+ Coverage   87.70%   88.82%   +1.11%     
==========================================
  Files        1635     1418     -217     
  Lines       63875    56820    -7055     
  Branches     1173      695     -478     
==========================================
- Hits        56022    50469    -5553     
+ Misses       7543     6184    -1359     
+ Partials      310      167     -143
Flag Coverage Ξ”
integrationtests 64.66% <15.00%> (-0.08%) ⬇️
unittests 86.90% <92.30%> (+0.90%) ⬆️
Components Coverage Ξ”
api βˆ… <ΓΈ> (βˆ…)
pkg_aws_library βˆ… <ΓΈ> (βˆ…)
pkg_dask_task_models_library βˆ… <ΓΈ> (βˆ…)
pkg_models_library 91.49% <94.11%> (-0.01%) ⬇️
pkg_notifications_library 84.57% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.39% <100.00%> (ΓΈ)
pkg_service_integration 70.18% <ΓΈ> (ΓΈ)
pkg_service_library βˆ… <ΓΈ> (βˆ…)
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 85.50% <ΓΈ> (ΓΈ)
agent 96.46% <ΓΈ> (ΓΈ)
api_server 90.55% <ΓΈ> (ΓΈ)
autoscaling 96.08% <ΓΈ> (ΓΈ)
catalog 90.33% <ΓΈ> (ΓΈ)
clusters_keeper 99.24% <ΓΈ> (ΓΈ)
dask_sidecar 91.26% <ΓΈ> (ΓΈ)
datcore_adapter 93.19% <ΓΈ> (ΓΈ)
director 77.01% <ΓΈ> (+0.08%) ⬆️
director_v2 91.30% <ΓΈ> (ΓΈ)
dynamic_scheduler 97.21% <ΓΈ> (ΓΈ)
dynamic_sidecar 89.75% <ΓΈ> (ΓΈ)
efs_guardian 90.25% <ΓΈ> (ΓΈ)
invitations 93.28% <ΓΈ> (ΓΈ)
osparc_gateway_server βˆ… <ΓΈ> (βˆ…)
payments 92.66% <ΓΈ> (ΓΈ)
resource_usage_tracker 88.84% <ΓΈ> (-0.22%) ⬇️
storage 89.57% <ΓΈ> (ΓΈ)
webclient βˆ… <ΓΈ> (βˆ…)
webserver 86.21% <90.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update b50e7e8...1771b1c. Read the comment docs.

@GitHK GitHK added the πŸ€–-automerge marks PR as ready to be merged for Mergify label Jan 30, 2025
@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2025

Restarted CI due to failing tests

@pcrespov pcrespov force-pushed the is7097/licensed-items-db branch from ee2bd0e to fc51ade Compare January 30, 2025 12:36
@pcrespov pcrespov enabled auto-merge (squash) January 30, 2025 12:37
@GitHK GitHK removed the πŸ€–-automerge marks PR as ready to be merged for Mergify label Jan 30, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 30, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov pcrespov merged commit b837ee0 into ITISFoundation:master Jan 30, 2025
92 of 94 checks passed
@pcrespov pcrespov deleted the is7097/licensed-items-db branch January 30, 2025 14:23
@odeimaiz odeimaiz mentioned this pull request Jan 31, 2025
Merged
1 task
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 7, 2025
Closed
18 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

Assignees

@pcrespov pcrespov

Labels

a:database associated to postgres service and postgres-database package a:models-library a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

5 participants

@pcrespov @giancarloromeo @GitHK @sanderegg @matusdrobuliak66