Skip to content

🎨 [Frontend] UI/UX Data handling: Larger window and list view by default #7160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Feb 5, 2025
Merged

🎨 [Frontend] UI/UX Data handling: Larger window and list view by default #7160

merged 31 commits into from
Feb 5, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 3, 2025 •
edited
Loading

What do these changes do?

  • Larger window: Stanadalone window and access from Study Details
  • List view by default. Prettify list view: make less table like
  • Enable Delete call on folder

UIUX_Data

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Feb 3, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Feb 3, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 4, 2025 12:13
@odeimaiz odeimaiz added this to the Singularity milestone Feb 4, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] UI/UX Data handling: Larger window a list view by default 🎨 [Frontend] UI/UX Data handling: Larger window and list view by default Feb 4, 2025
GitHK
GitHK reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) February 4, 2025 15:40
@codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (aed987d) to head (5aaad47).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7160   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files        1636     1636           
  Lines       63958    63958           
  Branches     1179     1179           
=======================================
+ Hits        56081    56084    +3     
+ Misses       7565     7562    -3     
  Partials      312      312
Flag Coverage Δ *Carryforward flag
integrationtests 64.77% <ø> (+<0.01%) ⬆️
unittests 85.96% <ø> (ø) Carriedforward from 40fb43e

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.51% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.39% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 74.12% <ø> (ø)
pkg_settings_library 90.71% <ø> (ø)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 90.33% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.92% <ø> (ø)
director_v2 91.43% <ø> (ø)
dynamic_scheduler 97.17% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.95% <ø> (ø)
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.23% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed987d...5aaad47. Read the comment docs.

ignapas
ignapas reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just a couple of things...

  • do we want to ask for confirmation when deleting (specially folders)
  • does deletion work with multiselection?
    thanks!

pcrespov
pcrespov approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@odeimaiz
Copy link
Member Author

odeimaiz commented Feb 5, 2025

nice! just a couple of things...

  • do we want to ask for confirmation when deleting (specially folders)
  • does deletion work with multiselection?
    thanks!

Good point. I added a confirmation dialog, and yes, deletion works with multi-selection too.

@odeimaiz odeimaiz requested a review from ignapas February 5, 2025 10:06
@odeimaiz odeimaiz disabled auto-merge February 5, 2025 10:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit 4fa6ee2 into ITISFoundation:master Feb 5, 2025
94 checks passed
@odeimaiz odeimaiz deleted the ui-ux/data-handling branch February 5, 2025 11:36
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 7, 2025
Closed
18 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@odeimaiz @mrnicegyu11
🎨 [Frontend] UI/UX Data handling: Larger window and list view by defa…
744ceaf 
…ult (ITISFoundation#7160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@ignapas ignapas ignapas approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@calys calys Awaiting requested review from calys

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

5 participants

@odeimaiz @ignapas @GitHK @pcrespov @matusdrobuliak66