Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Feb 3, 2025

What do these changes do?

Kept as reference, changes will be introduced in smaller PRs.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added this to the Singularity milestone Feb 3, 2025
@giancarloromeo giancarloromeo self-assigned this Feb 3, 2025
@giancarloromeo giancarloromeo added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:director-v2 issue related with the director-v2 service a:database associated to postgres service and postgres-database package t:maintenance Some planned maintenance work labels Feb 3, 2025
@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 87.03%. Comparing base (36e3b06) to head (2d8b577).
Report is 96 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7161      +/-   ##
==========================================
- Coverage   87.72%   87.03%   -0.69%     
==========================================
  Files        1642     1636       -6     
  Lines       64231    64123     -108     
  Branches     1179     1179              
==========================================
- Hits        56347    55810     -537     
- Misses       7573     8002     +429     
  Partials      311      311              
Flag Coverage Δ
integrationtests 71.68% <47.82%> (+7.06%) ⬆️
unittests 85.71% <86.90%> (-0.32%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.51% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.14% <100.00%> (-0.25%) ⬇️
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 74.13% <ø> (ø)
pkg_settings_library 90.71% <ø> (ø)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.69% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.92% <ø> (-0.09%) ⬇️
director_v2 85.26% <87.87%> (-6.02%) ⬇️
dynamic_scheduler 97.17% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.95% <ø> (-0.17%) ⬇️
storage 86.68% <ø> (-2.89%) ⬇️
webclient ∅ <ø> (∅)
webserver 86.35% <81.94%> (+0.09%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e3b06...2d8b577. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo added the 🤖-do-not-merge (optional) blocks Mergify from merging the PR label Feb 4, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-do-not-merge (optional) blocks Mergify from merging the PR a:database associated to postgres service and postgres-database package a:director-v2 issue related with the director-v2 service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants