Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 5, 2025

What do these changes do?

  • ✨ added Postgres connection to the dynamic-scheduler
  • ♻️ added project_networks repository to the dynamic-scheduler, which will also be the future owner of this table, since it is only used for running services in a project

Bonus:

  • ♻️ reorganised env vars section for dynamic-schdlr inside docker-compose.yml
  • ♻️ log_context prints the line where it is used instead of the line in servicelib which was not that useful
  • ♻️ cleaned up cli and cli_tests for dynamic_scheduler

Related issue/s

How to test

Dev-ops checklist ⚠️

  • no changes required, added existing env vars to the service
  • No ENV changes or I properly updated ENV (read the instruction)

@GitHK GitHK self-assigned this Feb 5, 2025
@GitHK GitHK added a:director-v2 issue related with the director-v2 service a:dynamic-scheduler labels Feb 5, 2025
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (4653f36) to head (c059687).
Report is 276 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7170      +/-   ##
==========================================
+ Coverage   87.66%   88.36%   +0.69%     
==========================================
  Files        1641     1160     -481     
  Lines       64171    49841   -14330     
  Branches     1179      311     -868     
==========================================
- Hits        56253    44040   -12213     
+ Misses       7607     5732    -1875     
+ Partials      311       69     -242     
Flag Coverage Δ
integrationtests 63.67% <ø> (-0.93%) ⬇️
unittests 82.91% <100.00%> (-3.04%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 95.01% <ø> (+0.98%) ⬆️
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.50% <ø> (ø)
agent ∅ <ø> (∅)
api_server 91.58% <ø> (+1.02%) ⬆️
autoscaling 87.92% <ø> (-8.16%) ⬇️
catalog ∅ <ø> (∅)
clusters_keeper 89.11% <ø> (-10.14%) ⬇️
dask_sidecar 87.27% <ø> (-4.00%) ⬇️
datcore_adapter ∅ <ø> (∅)
director 93.59% <ø> (+16.66%) ⬆️
director_v2 91.30% <ø> (+0.01%) ⬆️
dynamic_scheduler 91.46% <100.00%> (-5.72%) ⬇️
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations 88.98% <ø> (-4.31%) ⬇️
payments 90.46% <ø> (-2.21%) ⬇️
resource_usage_tracker 90.39% <ø> (+1.43%) ⬆️
storage 92.26% <ø> (+2.68%) ⬆️
webclient ∅ <ø> (∅)
webserver 86.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4653f36...c059687. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK added this to the Singularity milestone Feb 5, 2025
@GitHK GitHK changed the title ✨ Prepare Postgres connection for dynamic-scheduler and refactor projects_networks usage ✨ Prepare Postgres connection for dynamic-scheduler and refactor projects_networks usage ⚠️ Feb 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

@GitHK GitHK changed the title ✨ Prepare Postgres connection for dynamic-scheduler and refactor projects_networks usage ⚠️ ✨ connect Postgres and add projects_networks to dynamic-scheduler ⚠️ Feb 6, 2025
@sanderegg sanderegg modified the milestones: Singularity, The Awakening Feb 24, 2025
@GitHK
Copy link
Contributor Author

GitHK commented Apr 28, 2025

closed in favour of #7600

@GitHK GitHK closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service a:dynamic-scheduler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants