Skip to content

🎨 Services metadata has icon field and API can get/update it πŸ—ƒοΈ #7174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Feb 10, 2025
Merged

🎨 Services metadata has icon field and API can get/update it πŸ—ƒοΈ #7174

merged 31 commits into from
Feb 10, 2025

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 5, 2025 •
edited
Loading

What do these changes do?

web
webserver
catalog
Catalog

Any service meta-data now defines an optional icon field to store a url for the service icon. This is exposed to the front-end via the web-api (v0.54.0) under /catalog/services. Note that this is NOT exposed to the public-api so Solver resource does not include an icon.

Details

  • πŸ—ƒοΈ new icon column in services_meta_data table
  • ♻️ refactors catalog models by using DBGet, DBPath and DBCreate suffixes
  • ✨ catalog API schemas (v0.8.0)
    • adds optional icon field to ServiceGetV2``ServiceUpdateV2 schemas
  • ✨ webserver API schemas (v0.54.0)
    • adds optional icon field to CatalogServiceGet/CatalogServiceUpdate schemas

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_*catalog*.py

cd services/catalog
make install-dev
make test-dev-unit

Dev-ops

NOne

@pcrespov pcrespov self-assigned this Feb 5, 2025
@codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 87.75%. Comparing base (70e88e8) to head (8648086).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7174      +/-   ##
==========================================
+ Coverage   87.70%   87.75%   +0.05%     
==========================================
  Files        1641     1635       -6     
  Lines       64177    64041     -136     
  Branches     1179     1179              
==========================================
- Hits        56286    56201      -85     
+ Misses       7580     7529      -51     
  Partials      311      311
Flag Coverage Ξ”
integrationtests 64.61% <ΓΈ> (+0.01%) ⬆️
unittests 86.44% <100.00%> (+0.32%) ⬆️
Components Coverage Ξ”
api βˆ… <ΓΈ> (βˆ…)
pkg_aws_library 94.02% <ΓΈ> (ΓΈ)
pkg_dask_task_models_library 97.09% <ΓΈ> (ΓΈ)
pkg_models_library 91.51% <100.00%> (+0.01%) ⬆️
pkg_notifications_library 84.57% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.39% <ΓΈ> (ΓΈ)
pkg_service_integration 70.03% <ΓΈ> (ΓΈ)
pkg_service_library 74.13% <ΓΈ> (ΓΈ)
pkg_settings_library 90.71% <ΓΈ> (ΓΈ)
pkg_simcore_sdk 85.50% <ΓΈ> (ΓΈ)
agent 96.46% <ΓΈ> (ΓΈ)
api_server 90.55% <ΓΈ> (ΓΈ)
autoscaling 96.08% <ΓΈ> (ΓΈ)
catalog 91.69% <100.00%> (+0.22%) ⬆️
clusters_keeper 99.24% <ΓΈ> (ΓΈ)
dask_sidecar 91.26% <ΓΈ> (ΓΈ)
datcore_adapter 93.19% <ΓΈ> (ΓΈ)
director 76.92% <ΓΈ> (ΓΈ)
director_v2 91.29% <ΓΈ> (-0.02%) ⬇️
dynamic_scheduler 97.17% <ΓΈ> (ΓΈ)
dynamic_sidecar 89.75% <ΓΈ> (ΓΈ)
efs_guardian 90.25% <ΓΈ> (ΓΈ)
invitations 93.28% <ΓΈ> (ΓΈ)
osparc_gateway_server βˆ… <ΓΈ> (βˆ…)
payments 92.66% <ΓΈ> (ΓΈ)
resource_usage_tracker 89.01% <ΓΈ> (+0.38%) ⬆️
storage 89.57% <ΓΈ> (ΓΈ)
webclient βˆ… <ΓΈ> (βˆ…)
webserver 86.27% <ΓΈ> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 70e88e8...8648086. Read the comment docs.

@pcrespov pcrespov added this to the Singularity milestone Feb 6, 2025
@pcrespov pcrespov force-pushed the is7158/icon-services branch from b661610 to 9acdf21 Compare February 6, 2025 10:37
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:database associated to postgres service and postgres-database package a:catalog catalog service labels Feb 6, 2025
@pcrespov pcrespov changed the title WIP: 🎨 Is7158/icon services WIP: 🎨 Services metadata include an icon πŸ—ƒοΈ Feb 6, 2025
@pcrespov pcrespov force-pushed the is7158/icon-services branch from 9acdf21 to 8af4eb6 Compare February 6, 2025 14:59
@pcrespov pcrespov mentioned this pull request Feb 6, 2025
Merged
@pcrespov pcrespov changed the title WIP: 🎨 Services metadata include an icon πŸ—ƒοΈ 🎨 Services metadata include an icon πŸ—ƒοΈ Feb 7, 2025
@pcrespov pcrespov marked this pull request as ready for review February 7, 2025 14:39
@pcrespov pcrespov enabled auto-merge (squash) February 7, 2025 14:43
odeimaiz
odeimaiz approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@pcrespov pcrespov changed the title 🎨 Services metadata include an icon πŸ—ƒοΈ 🎨 Services metadata has icon field and API can get/update it πŸ—ƒοΈ Feb 7, 2025
matusdrobuliak66
matusdrobuliak66 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

GitHK
GitHK reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@pcrespov pcrespov requested a review from GitHK February 7, 2025 16:08
sanderegg
sanderegg approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thanks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov pcrespov merged commit 36e3b06 into ITISFoundation:master Feb 10, 2025
93 checks passed
@pcrespov pcrespov deleted the is7158/icon-services branch February 10, 2025 13:42
@odeimaiz odeimaiz mentioned this pull request Feb 11, 2025
Merged
1 task
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@pcrespov @mrnicegyu11
🎨 Services metadata include an icon πŸ—ƒοΈ (ITISFoundation#7174)
0e23a53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo giancarloromeo is a code owner

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@pcrespov pcrespov

Labels

a:catalog catalog service a:database associated to postgres service and postgres-database package a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

5 participants

@pcrespov @GitHK @odeimaiz @sanderegg @matusdrobuliak66