Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 6, 2025

What do these changes do?

Fixes validation error in master deploy

  File "/home/scu/.venv/lib/python3.11/site-packages/pydantic/main.py", line 627, in model_validate
    return cls.__pydantic_validator__.validate_python(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pydantic_core._pydantic_core.ValidationError: 1 validation error for LicensedItemRestGet
licensed_resource_data.source.doi
  Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]
    For further information visit https://errors.pydantic.dev/2.10/v/string_type

Related issue/s

How to test

cd packages/models-library
make install-dev
pytest -vv tests/test_licenses

Dev-ops

@pcrespov pcrespov self-assigned this Feb 6, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Feb 6, 2025
@pcrespov pcrespov added this to the Singularity milestone Feb 6, 2025
@pcrespov pcrespov marked this pull request as ready for review February 6, 2025 09:31
@pcrespov pcrespov requested a review from odeimaiz February 6, 2025 09:32
@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (4653f36) to head (7407dd8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7177      +/-   ##
==========================================
- Coverage   87.66%   87.46%   -0.20%     
==========================================
  Files        1641     1318     -323     
  Lines       64171    54965    -9206     
  Branches     1179      570     -609     
==========================================
- Hits        56253    48073    -8180     
+ Misses       7607     6763     -844     
+ Partials      311      129     -182     
Flag Coverage Δ
integrationtests 77.54% <ø> (+12.95%) ⬆️
unittests 86.85% <100.00%> (+0.90%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.45% <100.00%> (+0.02%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 90.33% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.92% <ø> (ø)
director_v2 84.47% <ø> (-6.82%) ⬇️
dynamic_scheduler 97.17% <ø> (ø)
dynamic_sidecar 88.84% <ø> (-0.92%) ⬇️
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.01% <ø> (+0.05%) ⬆️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.90% <ø> (-1.32%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4653f36...7407dd8. Read the comment docs.

@pcrespov pcrespov enabled auto-merge (squash) February 6, 2025 09:35
@pcrespov pcrespov disabled auto-merge February 6, 2025 09:47
@pcrespov pcrespov merged commit 50b017d into ITISFoundation:master Feb 6, 2025
80 of 88 checks passed
@pcrespov pcrespov deleted the fix/doi-nullable branch February 6, 2025 09:47
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants