-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Enhances Iicence feature: new vendor phantoms and licensed-resource-data id (🚨)
#7179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Enhances Iicence feature: new vendor phantoms and licensed-resource-data id (🚨)
#7179
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7179 +/- ##
==========================================
- Coverage 87.66% 87.24% -0.43%
==========================================
Files 1641 1634 -7
Lines 64171 63998 -173
Branches 1179 1179
==========================================
- Hits 56255 55832 -423
- Misses 7605 7855 +250
Partials 311 311
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
packages/models-library/src/models_library/api_schemas_webserver/licensed_items.py
Show resolved
Hide resolved
idid
idid (🚨)
374a255 to
92046e7
Compare
mguidon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gracias. Ping me when this goes live
|
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw it live 👌



What do these changes do?
Enhancements of the licenses feature:
idneeded by the front-end (requested by @odeimaiz )Related issue/s
How to test
Manually tested in local deploy setting
.envwith envs in osparc-config MRComputationalPhantomsweb-api
GET v0/catalog/licensed-itemsresponds with{ # ... "data": [ { "licensedItemId": "5a66b856-b116-4309-a2f9-d3224f818326", "displayName": "SHO-RC-V1 V1.0", "licensedResourceType": "VIP_MODEL", "licensedResourceData": { "categoryId": "ComputationalPhantom", "categoryDisplay": "Phantom of the Opera", "source": { "id": 78, "description": "SPEAG Posable Hand Phantom for Clamshell Phones - Right", "thumbnail": "https://speag.swiss/assets/images/Sim4Life/semshorc.png", "features": { "name": "SHO-RC-V1", "version": "V1.0", "date": "2024-11-05", "functionality": "Posable" }, "doi": null }, "termsOfUseUrl": null }, "pricingPlanId": 1, "createdAt": "2025-02-06T12:38:54.079488Z", "modifiedAt": "2025-02-06T12:38:54.079488Z" } ] }public-api
GET /licensed-itemsproduces{ "items": [ { "licensed_item_id": "5a66b856-b116-4309-a2f9-d3224f818326", "display_name": "SHO-RC-V1 V1.0", "licensed_resource_type": "VIP_MODEL", "licensed_resource_data": { "source": { "id": 78, "doi": null, "features": { "date": "2024-11-05", "name": "SHO-RC-V1", "version": "V1.0", "functionality": "Posable" }, "thumbnail": "https://speag.swiss/assets/images/Sim4Life/semshorc.png", "protection": "Code", "description": "SPEAG Posable Hand Phantom for Clamshell Phones - Right", "license_key": "MODEL_SEMSHO_RC", "license_version": "V1.0", "available_from_url": null }, "category_id": "ComputationalPhantom", "category_display": "Phantom of the Opera" }, "pricing_plan_id": 1, "created_at": "2025-02-06T12:38:54.079488Z", "modified_at": "2025-02-06T12:38:54.079488Z" } ], "total": 1, "limit": 20, "offset": 0, "links": { "first": "/v0/licensed-items?limit=20&offset=0", "last": "/v0/licensed-items?limit=20&offset=0", "self": "/v0/licensed-items?limit=20&offset=0", "next": null, "prev": null } }Dev-ops