Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 6, 2025

What do these changes do?

The web server's meta_modeling and version_control modules are built on top of the existing project interface. However, @giancarloromeo reported that maintaining compatibility with the current projects API has become increasingly burdensome, especially considering that these modules are not actively used.

This PR removes meta_modeling and version_control, allowing the project interface to be refactored and expanded without the constraints of backward compatibility. If needed in the future, these modules can be reintroduced and adapted to the updated projects API.

This PR acts as recovery point and is referenced in the documentation of the web-server

  • @odeimaiz the Statics API entry point will permanently include
{
  "disabledPlugins": ["WEBSERVER_META_MODELING", "WEBSERVER_VERSION_CONTROL"]
}

This ensures that the front-end keeps disabled these functionalities. At least while it exists in the front-end.

Related issue/s

How to test

cd services/web/server
make install-dev
make test-dev-unit
  • 🚨 test front-end runs a comp.service

Dev-ops ⚠️

  • deletes env vars *_META_MODELING and *_VERSION_CONTROL
  • Master MR: !1261
  • Staging MR: !1262
  • Production MR: !1263

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.25%. Comparing base (36e3b06) to head (b634391).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7182      +/-   ##
==========================================
- Coverage   87.72%   87.25%   -0.47%     
==========================================
  Files        1642     1641       -1     
  Lines       64231    64222       -9     
  Branches     1179     1085      -94     
==========================================
- Hits        56347    56038     -309     
- Misses       7573     7873     +300     
  Partials      311      311              
Flag Coverage Δ
integrationtests 64.62% <71.42%> (+<0.01%) ⬆️
unittests 86.25% <90.47%> (+0.22%) ⬆️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.51% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.21% <ø> (-0.19%) ⬇️
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 74.13% <ø> (ø)
pkg_settings_library 90.71% <ø> (ø)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.69% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 77.01% <ø> (ø)
director_v2 91.27% <ø> (ø)
dynamic_scheduler 97.17% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.95% <ø> (-0.17%) ⬇️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.73% <90.47%> (-1.53%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e3b06...b634391. Read the comment docs.

@pcrespov pcrespov self-assigned this Feb 6, 2025
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Feb 6, 2025
@pcrespov pcrespov force-pushed the mai/retire-meta-modeling branch 2 times, most recently from 4cec75f to 8215de5 Compare February 7, 2025 17:59
@pcrespov pcrespov added this to the Singularity milestone Feb 7, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Feb 7, 2025
@pcrespov pcrespov marked this pull request as ready for review February 7, 2025 18:00
@pcrespov pcrespov changed the title 🗑️ Retire webserver's project meta-modeling and version-control 🗑️ Retire webserver's project meta-modeling and version-control 🚨 Feb 7, 2025
@pcrespov pcrespov changed the title 🗑️ Retire webserver's project meta-modeling and version-control 🚨 🗑️ Retire webserver's project meta-modeling and version-control ⚠️ 🚨 Feb 7, 2025
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt read the code changes, accepting to unblock good luck with this :--)

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Please do not forget to add DB migration icon to the title

@pcrespov pcrespov changed the title 🗑️ Retire webserver's project meta-modeling and version-control ⚠️ 🚨 🗑️ Retire webserver's project meta-modeling and version-control ⚠️🚨🗃️ Feb 9, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pcrespov pcrespov force-pushed the mai/retire-meta-modeling branch from f8b2404 to b634391 Compare February 10, 2025 10:25
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants