Skip to content

🐛 Fix showing tags in usage overview #7183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

🐛 Fix showing tags in usage overview #7183

merged 2 commits into from
Feb 7, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Feb 7, 2025

What do these changes do?

  • 🐛 Fix showing tags in usage overview - tags should be shown based on root_parent_project_id (all projects/nodes created from root project ID should show the same tags)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 7, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Singularity milestone Feb 7, 2025
@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected a:resource-usage-tracker resource usage tracker service labels Feb 7, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 7, 2025 07:28
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 7, 2025 07:29
@codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (0eca9c2) to head (05e32fa).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7183      +/-   ##
==========================================
- Coverage   87.72%   84.68%   -3.04%     
==========================================
  Files        1641      689     -952     
  Lines       64177    32948   -31229     
  Branches     1179      262     -917     
==========================================
- Hits        56297    27902   -28395     
+ Misses       7569     4989    -2580     
+ Partials      311       57     -254
Flag Coverage Δ
integrationtests 64.60% <ø> (-8.40%) ⬇️
unittests 43.31% <ø> (-43.11%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.54% <ø> (-7.96%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.56% <ø> (-12.72%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker 89.06% <ø> (-0.06%) ⬇️
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 86.27% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eca9c2...05e32fa. Read the comment docs.

pcrespov
pcrespov approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this issue covered by any test? Please do not underestimate testing this corner cases... it can save you a lot of trouble in the future

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bisgaard-itis
bisgaard-itis approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the effort.

@matusdrobuliak66 matusdrobuliak66 merged commit eee4eb2 into ITISFoundation:master Feb 7, 2025
88 of 94 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 @mrnicegyu11
🐛 Fix showing tags in usage overview (ITISFoundation#7183)
1f50076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

a:resource-usage-tracker resource usage tracker service bug buggy, it does not work as expected

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

5 participants

@matusdrobuliak66 @giancarloromeo @pcrespov @odeimaiz @bisgaard-itis